Closed
Bug 1140162
Opened 9 years ago
Closed 9 years ago
IPC Proxy for TextAttributes and DefaultTextAttributes
Categories
(Core :: Disability Access APIs, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: smaug, Assigned: smaug)
Details
Attachments
(2 files, 1 obsolete file)
15.55 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
15.41 KB,
patch
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8573564 -
Flags: review?(tbsaunde+mozbugs)
Comment 1•9 years ago
|
||
Comment on attachment 8573564 [details] [diff] [review] v1 >diff --git a/accessible/atk/nsMaiInterfaceText.cpp b/accessible/atk/nsMaiInterfaceText.cpp >--- a/accessible/atk/nsMaiInterfaceText.cpp >+++ b/accessible/atk/nsMaiInterfaceText.cpp >@@ -1,32 +1,90 @@ > /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */ > /* vim: set ts=2 et sw=2 tw=80: */ > /* This Source Code Form is subject to the terms of the Mozilla Public > * License, v. 2.0. If a copy of the MPL was not distributed with this > * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ > > #include "InterfaceInitFuncs.h" >- >+#include "mozilla/a11y/PDocAccessible.h" given we end up needing to include this around a bit I'm kind of tempted to start dropping the silly wrappers on ProxyAccessible and just directly call stuff on DocAccessibleParent >+ConvertToAtkTextAttributeSet(nsTArray<Attribute>& aAttributes) >+{ >+ AtkAttributeSet* objAttributeSet = nullptr; >+ for (uint32_t i = 0; i < aAttributes.Length(); ++i) { technically I think it should be size_t since that's what Length() returns.
Attachment #8573564 -
Flags: review?(tbsaunde+mozbugs) → review+
Assignee | ||
Comment 2•9 years ago
|
||
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8574030 -
Attachment is obsolete: true
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/7fa300ea1b1d
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7fa300ea1b1d
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•