Closed Bug 1140164 Opened 9 years ago Closed 9 years ago

[STK] LAUNCH_BROWSER confirm message is not displayed if icon is self explanatory

Categories

(Firefox OS Graveyard :: Gaia, defect)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:2.2+)

Status:
RESOLVED DUPLICATE of bug 1140153
Project Flags:
blocking-b2g 2.2+

People

(Reporter: anshulj, Unassigned)

Details

(Whiteboard: [caf priority: p2][CR 804219]) 

Observed:LAUNCH_BROWSER confirm message is not displayed if icon is self explanatory
Expected: Confirm message should still be displayed with just an icon if the icon is self explanatory.

The root cause of the issue is that showURL function in icc.js at [1] only checks for text to be available before displaying the confirm message. Adding a (icons != null) check fixes the issue.

[1] http://lxr.mozilla.org/gaia/source/apps/system/js/icc.js#530
OS: Linux → Gonk (Firefox OS)
Hardware: x86_64 → ARM
Whiteboard: [CR 804219]
Whiteboard: [CR 804219] → [caf priority: p2][CR 804219]
NI fresla, to see if he can add that quick check.
Flags: needinfo?(frsela)
Blocks: CAF-v3.0-FL-metabug
No longer blocks: CAF-v3.0-FL-metabug
Is this a cert blocker or does it block CAF testing?
Flags: needinfo?(anshulj)
Wesley technically this breaks the spec so yes a cert blocker.
Flags: needinfo?(anshulj)
wesley, can you get this assigned?
blocking-b2g: 2.2? → 2.2+
The fix for bug 1140153 also fixes this issue.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Flags: needinfo?(frsela)
No longer blocks: CAF-v2.2-metabug
No longer blocks: CAF-v2.2-metabug
No longer blocks: CAF-v2.2-metabug
You need to log in before you can comment on or make changes to this bug.