1140181 - Log type of user for all requests

Status: RESOLVED FIXED

(Hello (Loop) :: Server, defect)

Description

[Katie Parlante]

RT's terminology for user type:

- Registered User: a FxA registered desktop client user
- Unregistered User: a non FxA registered desktop client user
- Link clicker user: a URL link clicker on a WebRTC browser
- Unreachable user: a URL link clicker on a non WebRTC browser

It would be ideal if we could log the type of user (as described above) for every loop server request.

Comment 1

[Rémy Hubscher (:natim)]

For the last one, how are we supposed to detect it on server side?

Comment 2

[Rémy Hubscher (:natim)]

Attachment: Link to Github PR — #318.

Comment 3

[Rémy Hubscher (:natim)]

What I can do is to return `Unreachable User` on the GET /rooms/:token when the user is not connected and then as soon as it uses its sessionToken, we can return a link-clicker User

Also a real Unreachable user will be somebody that doesn't have a "join" as a link-clicker on the same room.

Will that work for you or do you prefer us to call everyone Link-Clicker as soon as they are unauthenticated users?

Comment 4

[Rémy Hubscher (:natim)]

After thinking more about it, I think it is better to have only three user types:

- REGISTERED: "Registered User",
- UNREGISTERED: "Unregistered User",
- UNAUTHENTICATED: "Link-clicker User"

kparlante — does this works for you?

Comment 5

[Rémy Hubscher (:natim)]

We should use the user agent to detect that the Link-Clicker uses a non WebRTC browser.

Comment 6

[Katie Parlante]

(In reply to Rémy Hubscher (:natim) from comment #4)
> After thinking more about it, I think it is better to have only three user
> types:
> 
> - REGISTERED: "Registered User",
> - UNREGISTERED: "Unregistered User",
> - UNAUTHENTICATED: "Link-clicker User"
> 
> kparlante — does this works for you?

Yes, works for me.

(In reply to Rémy Hubscher (:natim) from comment #5)
> We should use the user agent to detect that the Link-Clicker uses a non
> WebRTC browser.

Agreed, that logic can live in the heka filter. Separate bug.

Comment 7

[Alexis Metaireau (:alexis)]

That's released. https://github.com/mozilla-services/loop-server/commit/9dbaade3b30d70570165a1a3307c6807013d7055