Closed
Bug 1140342
Opened 9 years ago
Closed 9 years ago
Remove __noSuchMethod__ from url-classifier/content/moz/debug.js
Categories
(Toolkit :: General, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(1 file)
|
1.44 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
__noSuchMethod__ is a non-standard feature that we want to remove from SpiderMonkey. Gavin, I'm not sure who should review this, the file hasn't been modified much since the switch to hg. Also, it looks like G_debugService is only used in #ifdef DEBUG code, so I'm not sure if stubbing these functions in non-DEBUG builds is even necessary, but this seemed the safest fix.
Attachment #8573863 -
Flags: review?(gavin.sharp)
|
||
Comment 1•9 years ago
|
||
Comment on attachment 8573863 [details] [diff] [review] Patch Scary that I think this code is mostly untested, but this looks complete.
Attachment #8573863 -
Flags: review?(gavin.sharp) → review+
|
Assignee | |
Comment 2•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/cb7d748abbe8
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/cb7d748abbe8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•