1140525 - [RTL][Rocketbar] Search engine value selector blue triangle icon looks jagged

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Search, defect, P2)

Description

[Pi Wei Cheng [:piwei] (inactive)]

Attachment: screenshot.png

Description:
When searching via Rocketbar, there is a search engine dropdown within the divider line, and the blue triangle icon has rough edges instead of showing a smooth edged icon.

Prerequisite:
In RTL language

STR:
1) On Homescreen, tap on Rocketbar
2) Type some characters into serach field, and notice the blue colored search engine drop down list triangle icon

Expected: Icon has smooth edges

Actual: Icon has a pixelated edge. See enlarged screenshot.

Device: Flame 3.0 (full flash 319MB)
BuildID: 20150306010207
Gaia: 7a91c16bfa348be8b25e09719178efa051512988
Gecko: 0189941a3fd5
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 39.0a1 (3.0 Master)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:39.0) Gecko/39.0 Firefox/39.0

Comment 1

[Pi Wei Cheng [:piwei] (inactive)]

This issue does not occur on Flame 2.2, BUT on Flame 2.2 the search engine value selector is NOT RTL'ed, it shows the blue triangle on the right side. I'm not sure if this counts as a regression or not. Possibly whatever made the value selector RTL'ed caused the issue?

Adding regression keyword for now.

Device: Flame 2.2
BuildID: 20150306002519
Gaia: eb86137e247224e86d17ed1a0a133b2a318dce3c
Gecko: a04034e239fb
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[KTucker [:KTucker][Inactive 3/4/2016]]

Please see bug 1137547 in regards to the search engine value selector not being RTL'ed in 2.2. This fix was landed on master but not 2.2 yet. We will check this again once the fix has been uplifted to 2.2.

Comment 3

[bhavana bajaj [:bajaj]]

blocking 2.2 as this is a fallout from this landing : https://bugzilla.mozilla.org/show_bug.cgi?id=1137547

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Confirmed that this issue is affecting 2.2 after the uplift.

Device: Flame 2.2 (full flash, 319MB)
BuildID: 20150311002522
Gaia: 3f032238a52f08e4c2f68a47ad065a96eb22d470
Gecko: 004fa1cb1dd4
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] benfrancis:1140525 > mozilla-b2g:master

Comment 6

[Dale Harvey (:daleharvey)]

Comment on attachment 8576148 [details] [review]
[gaia] benfrancis:1140525 > mozilla-b2g:master

Looks great cheers

Comment 7

[Ben Francis [:benfrancis]]

Thanks Dale

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/e358c1ba5782694eeb217436abbc00c310307859

Comment 9

[Norry.L.F(Leave from Mozilla)]

Attachment: Verify_master.png

The bug has been verifyed successfully on master.

Flame 3.0:
Build ID               20150312160232
Gaia Revision          eabe35cf054d47087b37c1ca7db8143717fbd7f3
Gaia Date              2015-03-12 18:01:49
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/42afc7ef5ccb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150312.194521
Firmware Date          Thu Mar 12 19:45:32 EDT 2015
Bootloader             L1TC000118D0

Comment 10

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15445/

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Please request Gaia v2.2 on this when you get a chance.

Comment 12

[Ben Francis [:benfrancis]]

Comment on attachment 8576148 [details] [review]
[gaia] benfrancis:1140525 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: pixelated UI
[Testing completed]: Manual
[Risk to taking this patch] (and alternatives if risky): Low, one line CSS change
[String changes made]: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/fd2728c4b76385aac123d93c16471cadedbe2857

Comment 14

[Parul Mathur [:pragmatic] - out of office - please ni? [:bajaj] instead]

Verified fixed on b2g v2.2 with the same Steps to Reproduce as comment 0.

Gaia-Rev        4e0633463571377ad4badc680b666771684e862d
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/535ec28fb36f
Build-ID        20150319162506
Version         37.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150319.200823
FW-Date         Thu Mar 19 20:08:34 EDT 2015
Bootloader      L1TC000118D0