1140802 - Deleting an event in the view after opening the event dialog via double-click causes a MODIFICATION_FAILED error

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Matthew Mecca [:mmecca]]

This is a follow up to Bug 1120258.

Opening an event for editing by double-clicking the event in the view, then deleting the event in the view while the dialog is still open, results in a MODIFICATION_FAILED error. Opening the event dialog using the view context menu, or from the today pane or unifinder, does not trigger the same error.

Comment 1

[Matthew Mecca [:mmecca]]

Attachment: Fix v1

Currently, opening the event dialog by double-clicking an item in the view is the only method that calls into the createPendingModification function, which tracks pending modification jobs in the event dialog, and attempts to complete those changes first if a subsequent modification is made before the dialog is closed. Since the fix for Bug 1120258 landed, that is no longer necessary, as the event dialog will observe those changes.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8574360 [details] [diff] [review]
Fix v1

Review of attachment 8574360 [details] [diff] [review]:
-----------------------------------------------------------------

Lets do it, thanks for looking into this! r/a=philipp

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/comm-central/rev/10ae8ea49f4e

Comment 4

[Martin Schröder [:mschroeder]]

Checkin for comm-aurora (4.0) is still missing!

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Backported to releases/comm-aurora changeset 8b4abb999d29