1140959 - [Stingray][Component] Move menu-group to gaia-components repository

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect)

Description

[KM Lee [:rexboy] (inactivate after Sep. 22)]

+++ This bug was initially created as a clone of Bug #1140958 +++

We are going to move menu-group component:
https://github.com/smart-components/menu-group
to gaia-components.

I think what we need to do are:
1. open a menu-group repo in gaia-components;
2. Review and check-in menu-group there
   (Pull request 1: to gaia-components/menu-group);
3. Make apps that is using menu-group point to gaia-components
   (Pull request 2: to gaia).

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/gaia-components/menu-group
I've pushed smart-components/menu-group to gaia-components/menu-group.

Now we need to modify bower.json, add readme, and review them.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch for gaia-components

This is patch for gaia-components repository.
After it got updated we need to update for Gaia repository too.

Tzu-lin may you help review this patch?

Comment 3

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8576570 [details] [review]
patch for gaia-components

Looks good to me, thanks

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Commit for gaia-components:
https://github.com/gaia-components/menu-group/commit/088b750c3fd32c898f2fc30125a41f59eaee1257

And let's patch Gaia master.
I think put them both in this patch should be more clear so let's just do it in this patch.

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Tzu-lin: this is Gaia side patch (1 of 3 commits in a pull request)
may you help review this bug?

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment on attachment 8577122 [details] [review]
patch

Looks good to me. Thanks

Comment 7

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/b093db8f38f119a95301c74d9b57fe7918247363