Closed
Bug 1141269
Opened 9 years ago
Closed 9 years ago
Thousands commas on Dashboard numbers
Categories
(Webtools Graveyard :: Air Mozilla, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: peterbe, Unassigned)
Details
(Whiteboard: [good first bug])
Attachments
(1 file)
17.66 KB,
image/png
|
Details |
When you visit the Dashboard you sometimes get really large numbers which are hard to read. "23792" is hard to read but "23,792" is easier to read. I think all numbers that are greater than 999 should be written with thousands commas (for example 1,234 instead of 1234).
Reporter | ||
Comment 1•9 years ago
|
||
This is going to mean you have to do it in Javascript. In fact, I think there are tools for AngularJS to do this kind of formatting.
Whiteboard: [good first bug]
Comment 2•9 years ago
|
||
I made a pull request for it here: https://github.com/mozilla/airmozilla/pull/232
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/airmozilla https://github.com/mozilla/airmozilla/commit/0dbcca145f2b4518cee78096f4c9ae08bd107de5 Fix bug 1141269 - Thousands commas on Dashboard numbers https://github.com/mozilla/airmozilla/commit/2f9d678a98b2b1c672a0f656564da6a7d0278148 Merge pull request #232 from blossomica/bug1141269-thousands-commas-on-Dashboard-numbers Fix bug 1141269 - Thousands commas on Dashboard numbers
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 4•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/airmozilla https://github.com/mozilla/airmozilla/commit/9eb51fadfb7709ee85122fe230cb0dbb344ed4cf Fix bug 1141269 - Thousands commas on Dashboard numbers https://github.com/mozilla/airmozilla/commit/7a296161d2af9d005f896241f232cce7c3ca364f Merge pull request #238 from blossomica/bug1141269-thousands-commas-on-Dashboard-numbers Fix bug 1141269 - Thousands commas on Dashboard numbers [Additional Edit]
Updated•3 years ago
|
Product: Webtools → Webtools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•