1141825 - Platforms that can't --enable-gmp-sandbox shouldn't load GeckoMediaPlugins

Status: NEW

(Core :: WebRTC: Audio/Video, defect, P3)

Description

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

+++ This bug was initially created as a clone of Bug #1120045 +++

(In reply to Randell Jesup [:jesup] from bug 1120045 comment #7)
> Seems straightforward, unless I'm missing something:
> 
> 1. Platform or system that doesn't support sandboxing (BSD, etc):
>    Default: disallow GMP (all)
>    pref set: allow unsandboxed GMP/OpenH264 (but not CDMs)
> 2. Platform/system does allow sandboxing:
>    Allow GMP (all)

This indicates to me that --enable-gmp-sandbox / MOZ_GMP_SANDBOX should be changed to control whether GMP support is part of Gecko — and probably renamed to drop the “sandbox”.

Comment 1

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Also relevant here: B2G.  Currently --disable-gmp-sandbox and currently not using media plugins, but that might change.

Comment 2

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

(In reply to Jed Davis [:jld] from comment #1)
> Also relevant here: B2G.  Currently --disable-gmp-sandbox and currently not
> using media plugins, but that might change.

s/might/will/.  Bug 1142899.

Comment 3

[Maire Reavy [:mreavy]]

Jed - Can you take this?  Thanks

Comment 4

[Jed Davis [:jld] ⟨⏰|UTC-7⟩ ⟦he/him⟧]

Should B2G be exempt from this requirement, or will it also need GMP sandboxing?

In either case it might make sense to allow GMP sandboxing to remain optional on B2G for now, and then make it mandatory when and if it's all working.

Comment 5

[Maire Reavy [:mreavy]]

(In reply to Jed Davis [:jld] from comment #4)
> Should B2G be exempt from this requirement, or will it also need GMP
> sandboxing?
> 
> In either case it might make sense to allow GMP sandboxing to remain
> optional on B2G for now, and then make it mandatory when and if it's all
> working.

I'm good with going forward in this bug under those assumptions, but before we go too far, we should reach out to B2G folks and cpearce and get their buy-in.

Comment 6

[Bulk Bug Changes for mreavy's org]

Mass change P2->P3 to align with new Mozilla triage process.