1142022 - Auto ack/nack in pulse-go library

Status: RESOLVED MOVED

(Taskcluster :: UI, defect, P5)

Description

[Pete Moore [:pmoore][:pete]]

PulseLibrary in taskcluster-client automatically acks/nacks. This was introduced here:
  * https://github.com/taskcluster/taskcluster-client/commit/a236d48b9907581dedcfa3e97fee6739336df847#diff-bdeec392e02b8fc5c8a9ac0b62f3b398R349

It would be good to introduce some auto-acking/nacking into the pulse go client, around here:
  * https://github.com/petemoore/pulse-go/blob/master/pulse/pulse.go#L291

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

What do you do at the moment?

IMO you should just let the handler return an error, if you want nack, and otherwise ack when handler returns.

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

Pete, is this a good mentored bug? Is pulse-go still a going (sorry) concern?

Comment 3

[Pete Moore [:pmoore][:pete]]

Let's just make this a P5. There isn't currently anything in production that relies on the go pulse client, so it isn't so important. The workers don't interface directly with pulse.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

For other languages, we're deprecating the idea of a pulse-specific library in favor of just using native AMQP libraries. Should we do the same with Go? In other words, deprecate use of pulse-go?

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

https://github.com/taskcluster/pulse-go/issues/6