Closed
Bug 1142584
Opened 9 years ago
Closed 9 years ago
Fix nsEscape.cpp compilation on mingw GCC 4.8.
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: jacek, Assigned: jacek)
Details
Attachments
(1 file)
|
864 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
I've got a report from Michael Cronenworth: In the process of updating Fedora for the new wine-gecko release I ran across an issue with the older gcc in Fedora 20. Fedora 20 uses gcc 4.8 while newer Fedoras use gcc 4.9+. There was a change in the typedef of char_type that results in a conversion failure on gcc 4.8. It seems that GCC 4.8 can't handle templates in thiscase, because they require one more implicit cast (due to tricky char16ptr_t type). Being explicit about template type fixes the problem.
Attachment #8576730 -
Flags: review?(nfroyd)
|
||
Updated•9 years ago
|
Attachment #8576730 -
Flags: review?(nfroyd) → review+
|
Assignee | |
Comment 1•9 years ago
|
||
Thanks for review. https://hg.mozilla.org/integration/mozilla-inbound/rev/c4a67c331727
https://hg.mozilla.org/mozilla-central/rev/c4a67c331727
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•