1142994 - Consolidate the terms and order used in Job Details pane and Similar Jobs pane

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P5)

Description

[Jonathan French (:jfrench)]

In the Job Details pane (bottom-left-bottom) we have:

Request Time
Start Time
End Time

In our continued goal to declutter, I'd like to remove the "Time" since its adjacent value is implicitly time:

Requested
Started
Ended

I'd also like to match that in Similar Jobs, and reorder a couple of items there so they present in the same order as the Job Details pane.

Comment 1

[Jonathan French (:jfrench)]

Attachment: treeherder-ui-PR#421

Please see above PR for status and review.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 8577258 [details] [review]
treeherder-ui-PR#421

Looks better, thank you :-)

(No need to comment on the PR saying I've given permission, should you not wish to; we trust you :-))

Comment 3

[Jonathan French (:jfrench)]

Will do, thanks Ed :)

Comment 4

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder-ui

https://github.com/mozilla/treeherder-ui/commit/3fab885e1925306b6c6dbc597449f17348747d38
Bug 1142994 - Consolidate terms and order in Job details panel

https://github.com/mozilla/treeherder-ui/commit/4b4acfaee82265e6c90db87fb34a9f0922b0afa2
Merge pull request #421 from tojonmz/job-detail-consistency

Bug 1142994 - Consolidate terms and order in Job details panel

Comment 5

[Jonathan French (:jfrench)]

Marking fixed per above merge. Will verify on the next push to stage/prod.

Comment 6

[Jonathan French (:jfrench)]

Sitting on this for a few days my "Started" and "Ended" seems a little pedantic. I'm inclined to change these two, just to "Start" and "End". I will check in on IRC tomorrow and see if anyone objects.

Comment 7

[Jonathan French (:jfrench)]

I looked at it again this morning and meh, I think we'll just leave it for now. 'Started' seems to make more sense in Similar Jobs. So past-tense for everything and we can always tweak later.

Comment 8

[Jonathan French (:jfrench)]

Verified fixed on stage.

Comment 9

[Treeherder GitHub Bugbot]

Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/f362fbf8df80475b75d4960f7034c8cf6c35bd50
Bug 1142994 - Consolidate terms and order in Job details panel

https://github.com/mozilla/treeherder/commit/f252e55cdd577aad01181b99490016a00766d20d
Merge pull request #421 from tojonmz/job-detail-consistency

Bug 1142994 - Consolidate terms and order in Job details panel