1143034 - Hide Reading List icon from overflow menu if reading list is hidden from homescreen

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Reader View, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150312145801

Steps to reproduce:

If the reading list is hidden via the homescreen customisation panel, we should assume that the user wants to disable it. Thus we should hide the icon in the overflow menu. Would be awesome to hide it in the location bar too.

Comment 1

[Aaron Train [:aaronmt]]

These special case conditions are getting complex.

Comment 2

[:Margaret Leibovic]

I don't think we need to support this. Currently, you can hide your bookmark panel, but we don't disable the bookmark start. And even if you have the reading list panel hidden, you may want to add something to your reading list to read later on desktop.

Comment 3

[Paul [pwd]]

(In reply to Aaron Train [:aaronmt] from comment #1)
> These special case conditions are getting complex.

The whole overflow menu currently has a few too many icons. I remember that I filed bug 1122511 a ways back about using a bottom sheet[1] for share. You could present the My Firefox stuff and perspective share intents in-line. It would make sense rather than having it in the overflow and then in My Firefox as well.

[1] https://www.google.com/design/spec/components/bottom-sheets.html

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to :Margaret Leibovic from comment #2)
> I don't think we need to support this. Currently, you can hide your bookmark
> panel, but we don't disable the bookmark start. And even if you have the
> reading list panel hidden, you may want to add something to your reading
> list to read later on desktop.

I agree. Let's not try to hide all the UI if the panel is hidden. If the goal is to customized the overflow menu, then that's a separate bug/feature.

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

We can continue further investigation into changing the flow in bug 1122511.