Closed
Bug 1143214
Opened 9 years ago
Closed 9 years ago
[Tab View/Task Manager] SSL Lock looks too small and text alignment needs to be updated
Categories
(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)
Tracking
(b2g-v2.2 verified, b2g-v2.5 verified, b2g-master verified)
VERIFIED
FIXED
2.2 S9 (3apr)
People
(Reporter: epang, Assigned: sfoster)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(5 files)
51.78 KB,
image/png
|
Details | |
474.71 KB,
image/jpeg
|
Details | |
46 bytes,
text/x-github-pull-request
|
etienne
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
58.07 KB,
image/png
|
epang
:
ui-review+
|
Details |
469.13 KB,
image/png
|
Details |
Hey Sam, There's something odd going on with the ssl lock (I'm pretty sure it was fine before). This effects both the task manager and tab view (found when testing private browsing). Can you check if the correct icons are being used? https://mozilla.box.com/s/3l26suxa00ci2bhktvk2wi1rscr3cf39 Also a few other changes needed: 1. The lock and icon should be centered in the space available. Right now it's looking right aligned 2. The URL should be italicized let me know if you have any questions, thanks!
Assignee | ||
Comment 1•9 years ago
|
||
Eric, can you annotate the screenshot or point out the problem? I'm not clear what the issue is in the attachment #8577498 [details]
Flags: needinfo?(epang)
Reporter | ||
Comment 2•9 years ago
|
||
Hey Sam, Sorry I was in a rush when filing the bugs. I've attached an image that goes into more detail (found a few out adjustments needed). Let me know if you have any questions! Thanks!
Flags: needinfo?(epang) → needinfo?(sfoster)
Comment 3•9 years ago
|
||
Assignee | ||
Comment 4•9 years ago
|
||
Turns out the ssl lock icon asset has some padding around it and we were scaling it down. I got that fixed and I think the alignment, italic, colors etc. This shows task-manager, tab-view, RTL side-by-side
Flags: needinfo?(sfoster)
Attachment #8583497 -
Flags: ui-review?(epang)
Assignee | ||
Comment 5•9 years ago
|
||
Comment on attachment 8583496 [details] [review] [gaia] sfoster:task-manager-subtitle-tweak-bug-1143214 > mozilla-b2g:master Some CSS tweaks to the lock icon and subtitle for cards in task-manager & tab view
Attachment #8583496 -
Flags: review?(etienne)
Assignee | ||
Comment 6•9 years ago
|
||
Comment on attachment 8583496 [details] [review] [gaia] sfoster:task-manager-subtitle-tweak-bug-1143214 > mozilla-b2g:master Adding Kevin as Etienne is kinda on PTO apparently. I'm out on PTO myself until next week. Could I ask one of you to see this lands and nominate this for 2.2 if it gets r+ and ui-review+? I'm not sure if it will make the cut but I'm sure Eric would like me to try and its super-low risk?
Attachment #8583496 -
Flags: review?(etienne) → review?(kgrandon)
Comment 7•9 years ago
|
||
Comment on attachment 8583496 [details] [review] [gaia] sfoster:task-manager-subtitle-tweak-bug-1143214 > mozilla-b2g:master stamp :)
Attachment #8583496 -
Flags: review?(kgrandon) → review+
Reporter | ||
Comment 8•9 years ago
|
||
Comment on attachment 8583497 [details]
task-manager-subtitle.png
Looks good, thanks Sam :)
Attachment #8583497 -
Flags: ui-review?(epang) → ui-review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Updated•9 years ago
|
Keywords: checkin-needed
Comment 9•9 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/109eb755bf46e36778f66cc5cb49470b040dadbd
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 10•9 years ago
|
||
Comment on attachment 8583496 [details] [review] [gaia] sfoster:task-manager-subtitle-tweak-bug-1143214 > mozilla-b2g:master [Approval Request Comment] This is a polish/paper-cut bug with task manager. UI is functional without but its a v. low risk, CSS only patch we would like to get into v2.2 if possible [Bug caused by] (feature/regressing bug #): Task Manager [User impact] if declined: Lock icon is small, sub-title (URL) is not correctly aligned. Text color is low-contrast. [Testing completed]: Tested on device, UI reviewed [Risk to taking this patch] (and alternatives if risky): V. low, CSS-only patch for polish issue [String changes made]: None
Attachment #8583496 -
Flags: approval-gaia-v2.2?
Comment 12•9 years ago
|
||
(In reply to Sam Foster [:sfoster] from comment #11) > Bhavana, is this on your radar? we need to stick to approving *blockers* alone at this time, so anything else will be out of my watch unless NI'ed. Given this came in right before FC and is super low risk, I am approving but will have to start minusing these requests from now on.
Flags: needinfo?(bbajaj)
Updated•9 years ago
|
Attachment #8583496 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Assignee | ||
Comment 13•9 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/022eeb91197ba4a9adfd67bd6db5aa03cc69eb31
Updated•9 years ago
|
Comment 14•9 years ago
|
||
This bug has been verified as "pass" on the latest build of Flame v2.2&2.5&master and Aries KK v2.5&master. STR: 1. View some websites in Browser/private browsing. 2. Enter Tab View/Task Manager. Actual results: a. The sub-title/URL is italic and horizontally centered aligned. b. The color of the "Lock" icon and text is correctly. c. The "Lock" icon is not small and is suitable. See attachment: verified_Flame_master.png Reproduce rate: 0/10 Device: Flame master_512mb (Pass) Build ID 20151216150211 Gaia Revision a84c2dbe672583914d04380cd61a56f1c60c3b8e Gaia Date 2015-12-16 06:59:39 Gecko Revision https://hg.mozilla.org/mozilla-central/rev/0babaa3edcf908c393b68a3dc2d1c2a2450c31ed Gecko Version 46.0a1 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151216.185725 Firmware Date Wed Dec 16 18:57:38 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK master (Pass) Build ID 20151216115605 Gaia Revision a84c2dbe672583914d04380cd61a56f1c60c3b8e Gaia Date 2015-12-16 06:59:39 Gecko Revision https://hg.mozilla.org/integration/mozilla-inbound/rev/0babaa3edcf908c393b68a3dc2d1c2a2450c31ed Gecko Version 46.0a1 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151216.113143 Firmware Date Wed Dec 16 11:31:51 UTC 2015 Bootloader s1 Device: Flame 2.5_512mb (Pass) Build ID 20151217001512 Gaia Revision 062e0fa48c1b5d5156f6911a5a4519128fac3231 Gaia Date 2015-12-11 15:06:09 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fc571094879466cb3ae35bc3bb32a7832bbfcade Gecko Version 44.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151216.232554 Firmware Date Wed Dec 16 23:26:04 UTC 2015 Firmware Version v18D v4 Bootloader L1TC000118D0 Device: Aries KK 2.5 (Pass) Build ID 20151217001840 Gaia Revision 062e0fa48c1b5d5156f6911a5a4519128fac3231 Gaia Date 2015-12-11 15:06:09 Gecko Revision http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/fc571094879466cb3ae35bc3bb32a7832bbfcade Gecko Version 44.0 Device Name aries Firmware(Release) 4.4.2 Firmware(Incremental) eng.worker.20151216.232744 Firmware Date Wed Dec 16 23:27:52 UTC 2015 Bootloader s1 Device: Flame 2.2_512mb (Pass) Build ID 20151216032502 Gaia Revision 885647d92208fb67574ced44004ab2f29d23cb45 Gaia Date 2015-10-07 13:05:24 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/2120b3e6f680 Gecko Version 37.0 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20151216.072742 Firmware Date Wed Dec 16 07:27:53 EST 2015 Firmware Version v18D v4 Bootloader L1TC000118D0
Comment 15•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•