1143319 - Search activity doesn't respect "Show search suggestions" setting

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Search Activity, defect)

Description

[john.morahan]

Attachment: suggestions.png

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0
Build ID: 20150306140254

Steps to reproduce:

1. (menu) -> settings -> customise -> search -> disable "Show search suggestions"
2. Open the search activity from the widget
3. Enter some search terms


Actual results:

Suggestions from remote search engines are displayed


Expected results:

No suggestions are not displayed, or only suggestions from local search history are displayed

Comment 1

[:Margaret Leibovic]

Thanks for filing. I don't think we considered that preference when creating the search activity, since we added that originally only for suggestions when typing in the urlbar.

antlam, what do you think we should do here? I feel like the search activity isn't very useful without search suggestions, but we may still want to respect this pref. Either that, or make it clear that the setting is only about suggestions in the urlbar.

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

The Search Activity was not really designed to work with out suggestions so I'm leaning towards WONTFIX-ing this. I'd like this setting to remain pertaining to just general search. 

Since the user is already focused on searching with just one engine, I feel the value there is also rather small.

We could definitely make that clearer in the setting though. "Setting does not apply to Firefox Search."?

Comment 3

[john.morahan]

I meant to link to this, but I couldn't find it again until just now:

http://research.microsoft.com/apps/pubs/default.aspx?id=119060

(in case the value of disabling suggestions even with only one search engine was unclear)

Comment 4

[Jan Henning [:JanH]]

This is an ex-Search Activity now (bug 1221344).