1143506 - Give up on sync decoding if we get DrawResult::BAD_IMAGE

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Seth Fowler [:seth] [:s2h]]

It's possible to get the reftest harness into an infinite drawing loop if we ever return DrawResult::BAD_IMAGE, because DrawResult::BAD_IMAGE is unrecoverable, but we'll keep trying to draw because ShouldInvalidateToSyncDecodeImages() keeps returning true.

Let's make it return false in this scenario.

This is currently causing the 944353.jpg crashtest to fail intermittently. Once downscale-during-decode is enabled, it becomes permafail, so we need to land this first.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Give up on sync decoding if we get DrawResult::BAD_IMAGE

Here's the patch. It's a one-liner.

Comment 2

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/c82354a9cf84

Comment 3

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c82354a9cf84