Closed
Bug 1143833
Opened 9 years ago
Closed 9 years ago
Add tests for the ignoreSearch match mode in DOM cache
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla39
Tracking | Status | |
---|---|---|
firefox39 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
5.93 KB,
patch
|
bkelly
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #8578200 -
Flags: review?(bkelly)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Blocks: cachetests
Comment 2•9 years ago
|
||
Comment on attachment 8578200 [details] [diff] [review] Add tests for the ignoreSearch match mode in DOM cache Review of attachment 8578200 [details] [diff] [review]: ----------------------------------------------------------------- LGTM. Please add a test that ignores search and deals with fragments at the same time.
Attachment #8578200 -
Flags: review?(bkelly) → review+
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Ben Kelly [:bkelly] from comment #2) > LGTM. Please add a test that ignores search and deals with fragments at the > same time. test_cache_matchAll_request.js already does that, by using a fragment for request1 but not request3, and ensuring that they are both returned from an ignoreSearch matchAll query. Sorry if this was not obvious from the limited context. :-)
Assignee | ||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff73dd4e2d62
Comment 5•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ff73dd4e2d62
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•