Closed Bug 1143981 Opened 9 years ago Closed 9 years ago

Reroute all fetch tests through transparent serviceworker

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: nsm, Assigned: ehsan.akhgari)

References

Details

Attachments

(1 file)

This will allow us to make sure that a serviceworker that just forwards requests to fetch() acts like it isn't there and deals with cors/opaque response headers correctly.
Assignee: nobody → ehsan
Comment on attachment 8605292 [details] [diff] [review]
Reroute all fetch tests through a transparent service worker

Review of attachment 8605292 [details] [diff] [review]:
-----------------------------------------------------------------

Please update the <title>Bug XXXXXXX...</title> in all files. r=me with that.

::: dom/tests/mochitest/fetch/fetch_test_framework.js
@@ +117,5 @@
>        info(e.message);
>        return Promise.resolve();
>      })
>      .then(function() {
> +      if (parent.finishTest) {

if (parent && parent.finishTest) {

since this is used in the top level non-sw-intercepted tests.
Attachment #8605292 - Flags: review?(nsm.nikhil) → review+
https://hg.mozilla.org/mozilla-central/rev/1189f6ffc65e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: