1144054 - [Flame][Task Manager] User can switch recent apps in the background in confirm install app view.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Lancy(Leave from Mozilla)]

Attachment: log.txt

[1.Description]:
[Flame][v2.2&v3.0][Task Manager]User can switch between recent apps in the background in comfirm install app view.
See attachments:Video.mp4 and log.txt
Occurrence time:15:33

[2.Testing Steps]: 
1.Run some apps in the background.
2.Connect the network and launch Marketplace.
3.Select an app to download.
4.Slide from left/ right edge to right/ left.

[3.Expected Result]: 
4.User cannot switch recent apps in the background.

[4.Actual Result]: 
4.You can switch recent apps in the backgroud.

[5.Reproduction build]: 
Flame 2.2 build (Affected):
Build ID               20150316162504
Gaia Revision          d0e09d5e6367e558824f9cbf691da99cedf63037
Gaia Date              2015-03-16 17:14:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/793d61bb0bd4
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150316.195035
Firmware Date          Mon Mar 16 19:50:48 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build(Affected):
Build ID               20150316160204
Gaia Revision          4868c56c0a3b7a1e51d55b24457e44a7709ea1ae
Gaia Date              2015-03-14 18:50:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/436686833af0
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150316.193248
Firmware Date          Mon Mar 16 19:32:58 EDT 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
Free Test

[8.Note]:
Open Notifications and select Settings button, Settings will be launched in the background.

Comment 1

[Lancy(Leave from Mozilla)]

Attachment: Video.mp4

Comment 2

[Gregor Wagner [:gwagner]]

Etienne, Alive, can you take a look?

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Etienne, if you are occupied I could take it. Simple fix I think.

Comment 4

[Etienne Segonzac (:etienne)]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #3)
> Etienne, if you are occupied I could take it. Simple fix I think.

I'll send you the review :)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] etiennesegonzac:1144054 > mozilla-b2g:master

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8579282 [details] [review]
[gaia] etiennesegonzac:1144054 > mozilla-b2g:master

Here we go :)

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8579282 [details] [review]
[gaia] etiennesegonzac:1144054 > mozilla-b2g:master

so fast!

Comment 8

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/640001a772e4c9bd35a8b0017f842b86fbab95a8

Comment 9

[Hermes Cheng (inactive after July 27, 2015)]

Since it is a 2.2 blocker, could you please also uplift to v2.2? Thanks. ;)

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8579282 [details] [review]
[gaia] etiennesegonzac:1144054 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): the initial edge gesture landing
[User impact] if declined: see Description
[Testing completed]: edge gestures scenarios,  edge swiping during install and install cancellation
[Risk to taking this patch] (and alternatives if risky): low (simple patch with lots of tests)
[String changes made]: none

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.2 uplift.

Comment 12

[Shally Li（leave from Mozilla）]

This bug has been failed verified on latest Flame v3.0. The edge gesture and edge swiping does not work on install app view and install cancellation view. 
I will file a following up bug soon.
See attachments: verify_v3.0.MP4
Reproduce rate: 5/5

Device: Flame 3.0 (Fail)
Build ID               20150324160206
Gaia Revision          aebfbd998041e960cea0468533c0b5041b504850
Gaia Date              2015-03-24 17:08:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/264387e7e453
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150324.193523
Firmware Date          Tue Mar 24 19:35:34 EDT 2015
Bootloader             L1TC000118D0

Comment 13

[Shally Li（leave from Mozilla）]

Attachment: verify_3.0.mp4

Comment 14

[Shally Li（leave from Mozilla）]

I am so sorry to misunderstand this bug,please ignore Comment 12,thanks

Comment 15

[Shally Li（leave from Mozilla）]

According to the STR of Comment 0,this bug has been successfully verified on latest Flame v3.0. The edge gesture and edge swiping will not work on install app view and install cancellation view as expected. 
See attachment: verify_v3.0.
Reproduce rate: 0/5

Device: Flame 3.0 (Pass)
Build ID               20150324160206
Gaia Revision          aebfbd998041e960cea0468533c0b5041b504850
Gaia Date              2015-03-24 17:08:51
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/264387e7e453
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150324.193523
Firmware Date          Tue Mar 24 19:35:34 EDT 2015
Bootloader             L1TC000118D0

Leaving "verifyme" keyword for Flame v2.2 uplift.

Comment 16

[Etienne Segonzac (:etienne)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #11)
> Needs rebasing for v2.2 uplift.

I think we should uplift bug 1097296 first instead of doing a specific 2.2 patch (just asked for 2.2+ on the other bug).

Comment 17

[Hermes Cheng (inactive after July 27, 2015)]

NI myself for following 2.2 verification.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/795ec92565a90f8ccddd95e8cd3cf326b02cce1f

Comment 19

[Hermes Cheng (inactive after July 27, 2015)]

Lancy, could you please verify this bug? Thanks.

Comment 20

[Shally Li（leave from Mozilla）]

Hi Hermaes,

    Sync with reporter,this bug has been failed verified on latest Nightly Flame v2.2&3.0 by the following steps. 
    
Actual Results: Can switch recent apps in the background on install app view and install cancellation view.

See attachments: verify_v2.2&3.0.MP4 and new_logcat_1712.txt
Reproduce rate: 5/5

Repro STR:
1.Run some apps in the background.
2.Launch Marketplace.
3.Select an app to download.
4.Slide from left/ right edge to right/ left.
**Can not switch these recent apps in the background. --OK

The different steps:
5.Long tap Home button.
6.Select and tap an app on card view.
7.When returning "install app" view,slide from left/ right edge to right/ left.
**Can switch these recent apps in the background showing on the notification bar.--KO


Device: Flame 2.2 build(Fail)
Build ID               20150326164141
Gaia Revision          6d0174e28576f2f93e696a43d1ac3b03340117f6
Gaia Date              2015-03-26 21:47:33
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/820c2f2e817a
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.201153
Firmware Date          Thu Mar 26 20:12:05 EDT 2015
Bootloader             L1TC000118D0

Device: Flame 3.0 build(Fail)
Build ID               20150326160206
Gaia Revision          525c341254e08f07f90da57a4d1cd5971a3cc668
Gaia Date              2015-03-26 16:34:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/59554288b4eb
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150326.193247
Firmware Date          Thu Mar 26 19:32:58 EDT 2015
Bootloader             L1TC000118D0

Comment 21

[Shally Li（leave from Mozilla）]

Attachment: new_logcat_1712.txt

Comment 22

[Shally Li（leave from Mozilla）]

Attachment: verify_v2.2&3.0.mp4

Comment 23

[Hermes Cheng (inactive after July 27, 2015)]

Shally, I think this is another issue.

The original issue is that the user can switch application when he/she sliding left/right at "Install" dialog of Marketplace.

However, at comment 20, you used Task Manager to close Marketplace but the "Install" dialog still existed. Then, the app can be switched by sliding. The problem is why the dialog is still there. Please open another bug for it. 

Besides, if the original steps is passed, please close this bug. Thanks.

Comment 24

[Shally Li（leave from Mozilla）]

Ok,I will submit it soon,thanks.

Comment 25

[Shally Li（leave from Mozilla）]

Per Comment 15 & Comment 20 & Comment 23, this bug has been successfully verified on latest Nightly Flame v3.0&2.2. 

Actual Results: Can not switch these recent apps of the background on install app view and install cancellation view as expected. 
(Please see attachment: verify_v3.0.mp4)

Comment 26

[Shally Li（leave from Mozilla）]

The another bug is bug 1148733.

Comment 27

[Hermes Cheng (inactive after July 27, 2015)]

Shally, thanks!