Closed Bug 114423 Opened 23 years ago Closed 23 years ago

Make SVG ForeignObject work properly in linux

Categories

(Core :: SVG, defect)

Product:
Core
Component:
SVG
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: simmo, Assigned: alex)

Details

Attachments

(1 file, 1 obsolete file)

new patch
1.77 KB, patch
bbaetz
: review+
Details | Diff | Splinter Review 
Currently, in linux, SVG ForeignObject's will only work properly if preloaded in
cache. I will attach a patch that will alleiviate this by forcing a DoReflow().
Attached patch patch to fix (obsolete) — — Splinter Review 

    
    

    
  
This is ugly. Ugly. Ugly.

I'll check it in when I get home, unless alex beats me to it.

Did I mention ugly?

    
    

    
  
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Reopening & taking bug because this is not really a fix.


Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  
reassigning
Assignee: simm0 → alex.fritze
Status: REOPENED → NEW

    
    

    
  

      
      
      
      

        Attached patch
          
          
        new patch
        — 
          — Splinter Review
      

    


  
James (james.turner@crocodile-clips.com) has found the real reason why we mess
up here. It's two uninitialized vars in
nsSVGForeignObjectFrame::TransformVector(). A one-liner!
At the same time I've also corrected the way in which we apply transformations
to foreignObjects. Since we can't rotate them yet, we have to make sure the
(left, top) stays (left,top).

        Attachment #61088 -
        Attachment is obsolete: true

    
    

    
  
Comment on attachment 61595 [details] [diff] [review]
new patch

And because they were passed by reference, not value, the compiler didn't warn.
r=bbaetz

        Attachment #61595 -
        Flags: review+

    
    

    
  
Checked in.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED

    
    

    
  
Marking in‑testsuite+ since we have multiple foreignObject reftests now.
Flags: in-testsuite+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: