Closed
Bug 1144374
Opened 9 years ago
Closed 9 years ago
apz crash when a tab is moved to a new window
Categories
(Core :: Panning and Zooming, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
| Tracking | Status | |
|---|---|---|
| firefox39 | --- | fixed |
People
(Reporter: tenisthenewnine, Assigned: kats)
References
()
Details
(Keywords: crash, crashreportid)
Crash Data
Attachments
(1 file)
|
3.57 KB,
patch
|
botond
:
review+
|
Details | Diff | Splinter Review |
So, 1. Enable APZ in latest nightly 2. Browse to this URL and let flash load the game 3. Drag the tab to make a new window, the browser will crash with below crash report: https://crash-stats.mozilla.com/report/index/7b54a41c-68f8-4b27-8d5e-1e53e2150317 I can reproduce this easily.
(In reply to Grant from comment #0) > 2. Browse to this URL and let flash load the game Which URL?
Flags: needinfo?(tenisthenewnine)
Sorry, this one for example: http://www.flashgames247.com/play/16892.html
Flags: needinfo?(tenisthenewnine)
|
||
Updated•9 years ago
|
Blocks: apz-desktop
Crash Signature: [@ nsRefPtr<mozilla::layers::HitTestingTreeNode>::assign_with_AddRef(mozilla::layers::HitTestingTreeNode*) | mozilla::layers::APZCTreeManager::PrepareNodeForLayer(mozilla::layers::LayerMetricsWrapper const&, mozilla::layers::FrameMetrics const&, unsigned …
Component: Untriaged → Panning and Zooming
Keywords: crash,
crashreportid
Product: Firefox → Core
Might I add I can reproduce this both on Windows 10 TP and Windows 7. It says I'm using NT but that's just Windows 10
|
Assignee | |
Comment 4•9 years ago
|
||
I can reproduce this. I don't think Flash is necessary here; I can repro on the same page by attempting to drag the tab into a new window even though I don't have flash. I can investigate.
Assignee: nobody → bugmail.mozilla
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
Assignee | |
Comment 5•9 years ago
|
||
Looks like a layer is getting transplanted from one LayerManager to another, and the APZ code doesn't handle that properly. Fix attached.
Attachment #8580036 -
Flags: review?(botond)
|
|
Assignee | |
Updated•9 years ago
|
Summary: apz plugin crash when open new window → apz crash when a tab is moved to a new window
|
||
Updated•9 years ago
|
Attachment #8580036 -
Flags: review?(botond) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2463904da0cc
|
||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2463904da0cc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in
before you can comment on or make changes to this bug.
Description
•