1144403 - sdk/places/events leaks

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Comment 1

[Dave Townsend [:mossop]]

Attachment: pull request

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Comment on attachment 8578989 [details] [review]
pull request

If you think we can make a test for this then please include it if you have time for make a bug for it please.

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Erik Vold [:erikvold] (please needinfo? me) from comment #2)
> Comment on attachment 8578989 [details] [review]
> pull request
> 
> If you think we can make a test for this then please include it if you have
> time for make a bug for it please.

*or make a bug

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/59e203705d1846e82112af706b4b9f6697513fa4
Bug 1144403: Fix sdk/places/events leaks by unregistering observers on unload.

https://github.com/mozilla/addon-sdk/commit/2710700094c3593b595631c7c4996d8a02b7fd1f
Merge pull request #1903 from Mossop/bug1144403

Bug 1144403: Fix sdk/places/events leaks by unregistering observers on unload. r=erikvold

Comment 5

[Dave Townsend [:mossop]]

Knee deep in leak fixes right now and since this is detectable by leak tools I think we can just make do with the follow-up bug 1144735.