1144413 - Remove "details" page from about:passwords

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Chenxia Liu [:liuche]]

The only actions that should be available on the about:passwords page will be from the context menu:
- Copy password (bug 1122225)
- Copy username
- Edit (bug 1144385)
- Delete (bug 1143939)

and the details page should be completely eliminated.

Comment 1

[Chenxia Liu [:liuche]]

Talked to antlam, and this should be similar to the "Add login" page (bug 1128526).

Comment 2

[Chenxia Liu [:liuche]]

Er, "Edit" in comment 1 links to the wrong bug - that is for Doorhangers.

The Edit bug is actually bug 1148524.

Comment 3

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Attachment: prev_pw_edit_mock1.png

"details" for a saved login.

The awkward white space would normally be covered with a keyboard so I'm not too worried about the vertical alignment. I wanted to hide that in the mock to show the full button for you.

Comment 4

[Chenxia Liu [:liuche]]

Hm, this bug name is a bit confusing, so updating the title.

This should only happen after the context menu items are all complete.

Comment 5

[Chenxia Liu [:liuche]]

Comment on attachment 8602395 [details]
prev_pw_edit_mock1.png

Antlam, I'm moving your mock to bug 1148524.

...I still need to improve my bugfoo-ing, namely naming and keeping bugs discrete x_x

Comment 6

[Allison Naaktgeboren :ally]

Attachment: removeDetailsFromAboutPasswords

I did not remove showDetails() because it is used by onPopupState().

Comment 7

[Chenxia Liu [:liuche]]

Comment on attachment 8614383 [details] [diff] [review]
removeDetailsFromAboutPasswords

This bug depends on bug 1148524, so I'm clearing the review flag until that is fixed.

Comment 8

[Chenxia Liu [:liuche]]

See comment 4.

Comment 9

[Chenxia Liu [:liuche]]

There's also a bug that I just discovered now where "back" on Details doesn't work anymore. But removing the details page will fix that :)

Comment 10

[Allison Naaktgeboren :ally]

The two bugs are independent of each other. I left the dependency tree as is when I took the bugs over, but I see no technical reason for that relationship

Comment 11

[Chenxia Liu [:liuche]]

I think the idea is that "Edit login" would replace the Details view, because you'd be able to see all the info about the login. However, now that we added Copy Username/Password, and also Show, the only extra thing that we have is Age which we decided we don't care about anyways.

I'm okay with removing this page entirely.

To summarize, we should remove _onPopState as well because it's no longer relevant (although you'll need it again for bug 1148524); you should also remove the details-related code from aboutPasswords.xhtml.

Comment 12

[Allison Naaktgeboren :ally]

Attachment: removeDetailsFromAboutPasswords v2

updated past about:logins refactor and including all the requests from comment 11.

Comment 13

[Chenxia Liu [:liuche]]

Comment on attachment 8621356 [details] [diff] [review]
removeDetailsFromAboutPasswords v2

Review of attachment 8621356 [details] [diff] [review]:
-----------------------------------------------------------------

You can also remove the .details css rules in aboutLogins.css.

Just a few things to check.

::: mobile/android/chrome/content/aboutLogins.js
@@ -346,1 @@
>    _openLink: function (clickEvent) {

Technically, we don't use this anymore, although we might want to use it later (does "Edit login" in about:logins need it?). I have a slight preference for removing it now and re-adding it later if we need to because then we don't accidentally forget about it, but up to you.

The same goes for _getElementForLogin.

Comment 14

[Allison Naaktgeboren :ally]

Attachment: removeDetailsFromAboutPasswords

Comment 15

[Allison Naaktgeboren :ally]

https://hg.mozilla.org/integration/fx-team/rev/c2522b713a74

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c2522b713a74