Closed Bug 114448 Opened 23 years ago Closed 23 years ago

IN CRL autoupdate prefs window, should remove the menu for update from url

Categories

(Core Graveyard :: Security: UI, defect, P1)

1.0 Branch
All
Windows NT
defect

Tracking

(Not tracked)

VERIFIED FIXED
psm2.2

People

(Reporter: rangansen, Assigned: rangansen)

Details

Attachments

(1 file)

This menu is not relevant unless we support any more options other than the 
'update from last fetched url'
Status: NEW → ASSIGNED
->me
Assignee: ssaux → rangansen
Status: ASSIGNED → NEW
Priority: -- → P1
Target Milestone: --- → 2.2
Attached patch patchSplinter Review
Removed the idea of advertised url altogether - untill we have support for the
same in NSS. So, urlType also goes away from prefs. Its always last fetch url.
Kai, Please review ...
Patch looks good, but one question: Why do you store the preference, when there
is only one possible setting? Should we remove that code, too?
Do you mean the storing the url string? [The url type is not being stored 
any amore]Because the autoupdate scheduler 
[nsNSSComponent::getParamsForNextCrlToDownload ]checks for which crl to update 
next, and then tries to import the crl directly from the corresp stored url 
string. This operation is much less costly than looking up for the crl in the 
db, and and finding out the lastfetchurl String 
Comment on attachment 61138 [details] [diff] [review]
patch

I thought you were storing a flag whether you do "last fetch" or "as
advertised".

r=kaie
Attachment #61138 - Flags: review+
Comment on attachment 61138 [details] [diff] [review]
patch

sr=hewitt
Attachment #61138 - Flags: superreview+
Patch checked in ...
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Verified.
Status: RESOLVED → VERIFIED
Product: PSM → Core
Version: psm2.2 → 1.0 Branch
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: