1144637 - [Shinano][Aries] Invalid WiFi MAC address

Status: RESOLVED FIXED

(Firefox OS Graveyard :: GonkIntegration, defect)

Description

[:gerard-majax]

Maybe the root cause of bug 1144623.

STR:
 0. Get a Z3/Z3 Compact device, look at MAC address in Settings, WiFi
 1. Get another Z3/Z3 Compact device, look at MAC address in Settings, WiFi

Expected:
 Different MAC address

Actual:
 Same MAC: 02:90:4c:c5:12:38

Comment 1

[:gerard-majax]

So that's default MAC address. Looks like we lack pushing the /system/bin/taimport blob.

Comment 2

[:gerard-majax]

Pushing /system/bin/taimport gets me a better MAC address, but now my device is always "offline" in adb :(

Comment 3

[:gerard-majax]

(In reply to Alexandre LISSY :gerard-majax from comment #2)
> Pushing /system/bin/taimport gets me a better MAC address, but now my device
> is always "offline" in adb :(

And that's solved by ro.adb.secure=0 in default.prop

Comment 4

[:gerard-majax]

Attachment: Shinano common PR

Not sure why this slipped through, I was convinced we already had this blob in place. We also need ro.adb.secure=0 otherwise adb is constantly 'offline'.

Comment 5

[Michael Wu [:mwu]]

Isn't ro.adb.secure something that's set depending on your build type? Not too comfortable overriding that property..

Comment 6

[:gerard-majax]

Not that I know off, it's used to control the adb authentication stuff as far as I could find.

Comment 7

[Michael Wu [:mwu]]

Comment on attachment 8579351 [details] [review]
Shinano common PR

Alright then.

Thought I think we should get support for secure mode at some point. ADB locking itself out when the lock screen comes up is insane.

Comment 8

[:gerard-majax]

From https://www.codeaurora.org/cgit/quic/la/platform/system/core/tree/adb/adb.c?h=kk_3.5_rb4.1#n1287 :
>    property_get("ro.adb.secure", value, "0");
>    auth_enabled = !strcmp(value, "1");
>    if (auth_enabled)
>        adb_auth_init();

I think it's pretty clear :)

Comment 9

[:gerard-majax]

(In reply to Michael Wu [:mwu] from comment #7)
> Comment on attachment 8579351 [details] [review]
> Shinano common PR
> 
> Alright then.
> 
> Thought I think we should get support for secure mode at some point. ADB
> locking itself out when the lock screen comes up is insane.

I remember seeing a bug for this, but I'm unable to find it :(

Comment 10

[:gerard-majax]

https://github.com/mozilla-b2g/device-shinano-common/commit/2edf7771f1b5e5cf39ea1d24d821b246a050c0aa

Comment 11

[Wander Lairson Costa]

Clearing NI.