1144642 - Missing string in Camera permission prompt for privileged and trusted hosted applications

Status: RESOLVED DUPLICATE of bug 1144784

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Maria Angeles Oteo (:oteo)]

Attachment: 2015-03-10-16-10-24.png

According to the Permissions table (http://mxr.mozilla.org/mozilla-central/source/dom/apps/PermissionsTable.jsm) for privileged and trusted hosted aplications that use Camera API a prompt should be shown to allow or not using this API.

Right now there is a string missing in the prompt (see attachment) about the permission that the users have to allow or not. This can be confusing and a string like "XXXXX app would like to access to your camera" is necessary.

W/GeckoConsole(15400): Content JS WARN: L10nError: "perm-camera-appRequest" not found in en-US in app://system.gaiamobile.org/index.html
W/GeckoConsole(15400):     at reportMissingEntity (app://system.gaiamobile.org/shared/js/l10n.js:1570:8)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] fcampo:camera-permission-1144642 > mozilla-b2g:master

Comment 2

[Fernando Campo (:fcampo)]

Comment on attachment 8581761 [details] [review]
[gaia] fcampo:camera-permission-1144642 > mozilla-b2g:master

small patch, only strings missing. 

Following same pattern as the rest of permissions

Comment 3

[Fernando Campo (:fcampo)]

Attachment: after_screenshot

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8581761 [details] [review]
[gaia] fcampo:camera-permission-1144642 > mozilla-b2g:master

If this needs to uplift to v2.2 you will need l10n guys feedback. r+ for master

Comment 5

[Maria Angeles Oteo (:oteo)]

It would be great if it could be uplifted to 2.2 (if it's set as 2.2+), but I am not sure if it's too late for localization team... Axel, are we still on time? In case we are, I'll nominate it.

Comment 6

[Francesco Lodolo [:flod]]

String freeze is on April 6, and approval needs to come from release drivers, not l10n ;-)

Comment 7

[Maria Angeles Oteo (:oteo)]

Nominating to 2.2 as this is a small and very low risk that patch that in case a third party application uses the camera API, the missing string in the permission prompt results confusing for the end-users.

Comment 8

[GitHub Autolander Bot]

http://docs.taskcluster.net/tools/task-graph-inspector/#IjCGuDisS6isMZ-rZ4gY1A

The pull request failed to pass integration tests. It could not be landed, please try again.

Comment 9

[Maria Angeles Oteo (:oteo)]

It seems that Borja already fixed this issue in bug 1144784, already landed in master.

Comment 10

[Stephany Wilkes]

Comment on attachment 8581770 [details]
after_screenshot

Removing the flag to me since this is resolved dupe.