1144722 - Hello button cannot be positioned at the top of Menu panel

Status: RESOLVED INCOMPLETE

(Firefox :: Toolbars and Customization, defect)

Description

[Ada [:adalucinet]]

Reproducible on Fx 37 beta 6 (Build ID: 20150316202753), Aurora 38.0a2 (Build ID: ) and Nightly 39.0a1 (Build ID: 20150318030202)
Affected platforms: Mac OS X 10.9.5, Windows 7 64-bit, Windows 8.1 32-bit and Ubuntu 14.04 32-bit

Steps to reproduce:
1. Launch Firefox.
2. Go to Menu Panel and click on Customize.
3. Drag&drop Hello button at top of the menu.

Expected results: Hello button is placed at the top of Menu panel.

Actual results: Hello button is misplaced.

Notes:
1. *Screencast*: http://goo.gl/sr6r2d
2. Regression range - (m-c):
Last good revision: c5b90c003be8 (2015-03-04)
First bad revision: 993eb76a8bd6 (2015-03-05)
Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c5b90c003be8&tochange=993eb76a8bd6

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Looks like it might be related to bug 1108187, which is confusing because that should have only affected private browsing. Maybe this uncovered a preexisting issue with Customize Mode and non-private-browsing mode buttons?

Comment 2

[Sashoto Seeam]

I have reproduced this bug on Nightly 39.0a1 (Build ID: 20150320030211) but I can take the hello button to top in Aurora 38.0a2 (Build ID: 20150304004138).
I'm using windows 8.1 x64 as my operating system.

Comment 3

[Mark Banner (:standard8)]

Looks like this would be the place to start looking:

http://hg.mozilla.org/mozilla-central/file/e730012260a4/browser/components/customizableui/PanelWideWidgetTracker.jsm#l108

Comment 4

[:Gijs (he/him)]

I'm pretty sure we don't let any non-private-browsing mode widgets ever appear before wide widgets.

The reason being that they would then cause empty space when the panel is opened in a private browsing window.

We can talk about alternative ways of addressing that, but I can't really think of any. Having the concrete nodes in the panel not match the placements in terms of order is going to break the world, so that isn't really an option.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Seems like the best way to fix this is to get Hello working in private windows, since that would be nice-to-have anyways :)

Comment 6

[Mark Banner (:standard8)]

Linking to the Hello private browsing bug.

Comment 7

[Mark Banner (:standard8)]

Support for Hello/Loop has been discontinued.

https://support.mozilla.org/kb/hello-status

Hence closing the old bugs. Thank you for your support.