1144834 - Move resetBufferedGrayRoots to GCRuntime

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Terrence Cole [:terrence]]

Attachment: 2.8_move_resetBufferedGrayRoots_to_GCRuntime-v0.diff

Comment 1

[Jon Coppeard (:jonco)]

Comment on attachment 8579568 [details] [diff] [review]
2.8_move_resetBufferedGrayRoots_to_GCRuntime-v0.diff

Review of attachment 8579568 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/RootMarking.cpp
@@ +580,5 @@
>  
> +    // If we OOMed while buffering gray roots, clear out the buffers since we
> +    // are not going to be using them anyway.
> +    if (grayBufferState == GrayBufferState::Failed)
> +        resetBufferedGrayRoots();

The previous sections might be clearer as:

if (marker.bufferingGrayRootsFailed) {
  grayBufferState = GrayBufferState::Failed;
  resetBufferedGrayRoots();
}

Comment 2

[Terrence Cole [:terrence]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef82c33387eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/a31a1564808a

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a31a1564808a