Closed Bug 1145388 Opened 9 years ago Closed 9 years ago

Reading list items not marked as read after viewing

Categories

(Firefox for iOS :: Reading List, defect)

Product:
Firefox for iOS
Component:
Reading List
Platform:
All
iOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: callahad, Assigned: st3fan)

References

Details

Attachments

(1 file)

PR: https://github.com/mozilla/firefox-ios/pull/734
47 bytes, text/x-github-pull-request
fluffyemily
: review+
tecgirl
: ui-review+
Details | Review 
I don't seem to be able to mark my reading list items as read, no matter how many times I click on them, visit the link, or click the little blue circle in the reader view.

iOS 8.2 / Build 5 / 5th Generation iPod Touch
tracking-fennec: --- → ?
Assignee: nobody → sarentz
Blocks: iosreadinglist
It is not implemented yet. But lets keep this on file.
tracking-fennec: ? → +
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
This is still problematic. Items one adds to one's reading list will never be marked as unread.
Status: RESOLVED → REOPENED
tracking-fxios: --- → ?
Resolution: FIXED → ---
You can mark items as read manually but they are never automatically marked as read. I'm not sure if this is design intentional but this goes against user expectation.
Summary: Items not marked (or markable) as read → Items not marked as read
Status: REOPENED → ASSIGNED
OS: Mac OS X → iOS
Hardware: x86 → All
Summary: Items not marked as read → Reading list items not marked as read after viewing
This patch marks reading list items as read when you open them. This is a very basic start. Let me know via *UI Review* if this is good enough via v1.
Attachment #8633616 - Flags: ui-review?(randersen)
Attachment #8633616 - Flags: ui-review?(dhenein)
Attachment #8633616 - Flags: review?(etoop)
Attachment #8633616 - Flags: ui-review?(randersen) → ui-review+
Comment on attachment 8633616 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/734

I would really like to see a test for this too.
Attachment #8633616 - Flags: review?(etoop) → review+
Attachment #8633616 - Flags: ui-review?(dhenein)
Added a UI test. Merged.

https://github.com/mozilla/firefox-ios/commit/5b0f65795ee1b2d27445a2651a5e0a5b4f0f8c0d
Status: ASSIGNED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: