Closed
Bug 1145795
Opened 9 years ago
Closed 9 years ago
Remove LJSCallInstructionHelper::numStackArgs()
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
| Tracking | Status | |
|---|---|---|
| firefox40 | --- | fixed |
People
(Reporter: efaust, Assigned: efaust)
Details
Attachments
(1 file)
|
5.30 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
This unfortunate function with the same name as MCall::numStackArgs(), subtracts 1 from the number. This makes unsupecting people not In The Know (like me, just now) throw a big animated exclamation point over their heads when reading code. Let's remove it, as it obscures more meaning than it provides.
|
Assignee | |
Comment 1•9 years ago
|
||
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8580924 [details] [diff] [review] fix Review of attachment 8580924 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this footgun.
Attachment #8580924 -
Flags: review?(jdemooij) → review+
|
||
Comment 3•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9db244d84c0b
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•