1146248 - Avoid concurrent dhcp_do_request execution

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Description

[Henry Chang [:hchang]]

The implementation of |dhcp_do_request| [1] is not a reentrant function since it uses a global properties (e.g. dhcp.wlan0.xxxx) to store the result. We need to make sure not calling |dhcp_do_request| while another one is running.

[1] http://androidxref.com/4.4.4_r1/xref/system/core/libnetutils/dhcp_utils.c#234

Comment 1

[Henry Chang [:hchang]]

Attachment: Bug1146248.patch

Comment 2

[Henry Chang [:hchang]]

Hi Selin,

Could you please check if this patch mitigate the DHCP re-request issue
that we discuss yesterday? Thanks!

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

I backport to v2.0m and try this patch. It works fine.

Comment 4

[Henry Chang [:hchang]]

Comment on attachment 8582148 [details] [diff] [review]
Bug1146248.patch

Review of attachment 8582148 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Vincent, could you please help review this patch to avoid concurrent dhcp request? Thanks!
What this patch does is pretty much the same as dhcp_stop()  [1]

http://androidxref.com/4.4.4_r1/xref/system/core/libnetutils/dhcp_utils.c#260

Comment 5

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8582148 [details] [diff] [review]
Bug1146248.patch

Review of attachment 8582148 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Thank you.

Comment 6

[Henry Chang [:hchang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81ece9aeeeda

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/0ac8ff6c3bed

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0ac8ff6c3bed

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: [v2.0m] Stop previous DHCP request when requesting a new one.

Henry, I rebased a patch for v2.0m branch, could you have a look? Thanks!

Comment 11

[Kai-Zhen Li [:seinlin][:kli]]

Josh, we need this patch for v2.0m.

Comment 12

[Henry Chang [:hchang]]

Comment on attachment 8586001 [details] [diff] [review]
[v2.0m] Stop previous DHCP request when requesting a new one.

Review of attachment 8586001 [details] [diff] [review]:
-----------------------------------------------------------------

looks good! Thanks!

Comment 13

[Kai-Zhen Li [:seinlin][:kli]]

https://hg.mozilla.org/releases/mozilla-b2g32_v2_0m/rev/51d8d4584b47

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for b2g34 and b2g37 when you get a chance.

Comment 15

[Henry Chang [:hchang]]

Comment on attachment 8582148 [details] [diff] [review]
Bug1146248.patch

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): DHCP
User impact if declined: Quickly run dhcp multiple times would fail to get corrent DHCP info
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch:No

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/1d6951d8832e
https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/6be6dcebc075

Comment 17

[Vincent Liu[:vliu]]

https://hg.mozilla.org/releases/mozilla-b2g34_v2_1s/rev/6be6dcebc075