1146252 - Remove fromTab and toTab properties from "select" events in tabbrowser.xml and tabbox.xml

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dão Gottwald [:dao]]

Bug 1135045 set fromTab and toTab properties on "select" events in browser/base/content/tabbrowser.xml and toolkit/content/widgets/tabbox.xml. Then bug 1144782 made us use the "TabSelect" event rather than the "select" event, leaving fromTab and toTab completely unused. So we should remove them.

The relevant code can be found here:

http://hg.mozilla.org/mozilla-central/annotate/e730012260a4/browser/base/content/tabbrowser.xml#l5523

http://hg.mozilla.org/mozilla-central/annotate/e730012260a4/toolkit/content/widgets/tabbox.xml#l667

Comment 1

[John Kang]

Did you want every instance of fromTab and toTab, including the enclosing if-else statements removed?

Comment 2

[Dão Gottwald [:dao]]

We should just stop setting event.fromTab and event.toTab in the code I pointed to. I'm not sure what if-else statements you mean.

Comment 3

[Mike de Boer [:mikedeboer]]

John, you basically only have to revert the following changes:

https://hg.mozilla.org/releases/mozilla-aurora/diff/f4c0e3fd326a/browser/base/content/tabbrowser.xml
https://hg.mozilla.org/releases/mozilla-aurora/diff/f4c0e3fd326a/toolkit/content/widgets/tabbox.xml

Not more.

Comment 4

[Mike de Boer [:mikedeboer]]

https://hg.mozilla.org/mozilla-central/diff/77e37031bb11/browser/base/content/tabbrowser.xml
https://hg.mozilla.org/mozilla-central/diff/77e37031bb11/toolkit/content/widgets/tabbox.xml

for the mozilla-central locations.

Comment 5

[John Kang]

Attachment: bug1146252.diff

Here you go! Please let me know if anything else is required or if I made a mistake. :)

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8582710 [details] [diff] [review]
bug1146252.diff

Looks good. Thanks!

Comment 7

[John Kang]

Great. Could I bother you again for a vouch?
https://mozillians.org/en-US/u/jkang8/

Comment 8

[Dão Gottwald [:dao]]

(In reply to John Kang from comment #7)
> Great. Could I bother you again for a vouch?
> https://mozillians.org/en-US/u/jkang8/

done!

Comment 9

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/fx-team/rev/a83feceee78b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a83feceee78b

Comment 11

[John Kang]

Hi, I'm still learning about contributing to Firefox. Is my patch already checked into the repository or do I need to still do it? Also, how do I have my contributions show up on my GitHub account?

Thanks.

Comment 12

[Dão Gottwald [:dao]]

(In reply to John Kang from comment #11)
> Hi, I'm still learning about contributing to Firefox. Is my patch already
> checked into the repository or do I need to still do it?

It has been checked in (comment 9) and merged to mozilla-central (comment 10).

> Also, how do I have my contributions show up on my GitHub account?

Sorry, I have no idea about that. Our primary repository is https://hg.mozilla.org/mozilla-central/. I think there's a mirror on GitHub, but it's read-only. I'm not sure whether that's relevant to your question.

Comment 13

[Tim Taubert [:ttaubert] (inactive)]

(In reply to Dão Gottwald [:dao] from comment #12)
> (In reply to John Kang from comment #11)
> > Also, how do I have my contributions show up on my GitHub account?
> 
> Sorry, I have no idea about that. Our primary repository is
> https://hg.mozilla.org/mozilla-central/. I think there's a mirror on GitHub,
> but it's read-only. I'm not sure whether that's relevant to your question.

Yes, as soon as that mirror is synced it'll show up as a contribution to mozilla/gecko-dev. In fact, I can already see it listed on your GitHub profile page :)