1146546 - Australis 'swoop' shape path is not as smooth/rounded as on desktop

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Theme & Visual Design, defect)

Description

[John Gruen [:jgruen]]

Attachment: Different Bezier paths on desktop and iOS

Attaching a picture for clarity. The Australis 'swoop' path on iOS appears to go vertical about mid-way through. Lacks the overall smoothness of it's desktop counterpart

Comment 1

[John Gruen [:jgruen]]

(In reply to [:jgruen] from comment #0)
> Created attachment 8581874 [details]
> Different Bezier paths on desktop and iOS
> 
> Attaching a picture for clarity. The Australis 'swoop' path on iOS appears
> to go vertical about mid-way through. Lacks the overall smoothness of it's*
> desktop counterpart

*its

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

On Android, we don't use exact same curve as Australis. That was an intentional decision because of both the implementation, and the device type, made with the considerations of Shorlander. 

But, that being said, the screen shot does look a bit different to even Android.

Wes, are we using the same curve as Android?

Comment 3

[Wesley Johnston (:wesj)]

Yes. I haven't overlaid them, but all the parameters are exactly the same.

Comment 4

[Darrin Henein [:darrin]]

You said you had the desktop one Wes?

Comment 5

[Wesley Johnston (:wesj)]

I found something in this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=921051 from when Desktop was going to ship SVG. It will take a little division to covert it to our w/h units. I hadn't got that far. Maybe someone in UX has a better version.

Comment 6

[Wesley Johnston (:wesj)]

Attachment: PR https://github.com/mozilla/firefox-ios/pull/415

This is a mostly direct (rounding errors) move to what's in those SVG files. I'll upload an overlay image. Its close to desktops, but.. well desktop uses images right now and they've got aliasing built in. Its hard to compare. At this point, I think UX will have to hand refine, but figured I could give you a start.

Comment 7

[Wesley Johnston (:wesj)]

Attachment: Overlay

Comment 8

[Darrin Henein [:darrin]]

Attachment: Sharp Curve Points

Hrm, seems to be closer by overlay, but still has some rough edges.

Comment 9

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Closing this with WORKSFORME because :darrin closed the PR for this one with "While I know this is the curve we use elsewhere, I think the extra control points add a few sharp-ish corners. I think what we have in trunk is fine for now."