1146786 - browser-sidebar logs lots of noise

Status: RESOLVED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0010-Bug-XXXXXXX-make-readinglist-sidebar-logs-less-noisy.patch

The logs for the sidebar end up in the readinglist "sync" logs (which seems fine) although they are a bit noisy.  This patch changes some log.debug calls to log.trace calls (.trace calls will *not* end up in these logs by default)

Comment 1

[Florian Quèze [:florian]]

Comment on attachment 8582220 [details] [diff] [review]
0010-Bug-XXXXXXX-make-readinglist-sidebar-logs-less-noisy.patch

Review of attachment 8582220 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/readinglist/sidebar.js
@@ +233,5 @@
>        log.error(`Unable to set selectedItem to invalid node ${node}`);
>        return;
>      }
>  
> +    log.trace(`Setting activeItem: ${node ? node.id : null}`);

While you are at it, please fix this to say "selectedItem" instead of "activeItem". I guess this was a copy/paste mistake initially.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

https://hg.mozilla.org/integration/fx-team/rev/b210e4342ee9

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b210e4342ee9

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8f553b5d1768