Closed
Bug 1147147
Opened 9 years ago
Closed 9 years ago
Partner repack changes for Yahoo -- US intl search URL and start page URL update
Categories
(Release Engineering :: Release Requests, defect)
Release Engineering
Release Requests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sdat27, Unassigned)
Details
Attachments
(2 files)
15.33 KB,
patch
|
mixedpuppy
:
review+
|
Details | Diff | Splinter Review |
15.33 KB,
patch
|
Details | Diff | Splinter Review |
Hi, We found that the search URL and start page URL are outdated and have updated them for US intl. Please review and integrate the changes. Overview of changes: 1. Search URL changed to be "https://search.yahoo.com/yhs/search?ei=UTF-8&fr=chrf-yff37&hspart=mozilla&hsimp=yhs-002&p={query}" instead of "https://search.yahoo.com/search?ei=UTF-8&fr=chrf-yff37&p={query}" 2. Browser startup homepage changed to be "about:newtab" instead of "https://search.yahoo.com/firefox/?fr=sfp-yff37" Thanks, Sneha
Updated•9 years ago
|
Attachment #8582680 -
Flags: review+
Comment 1•9 years ago
|
||
Comment on attachment 8582680 [details] [diff] [review] repack_config_changes_for_yahoo.diff Changing to r-, the patch doesn't apply.
Attachment #8582680 -
Flags: review+ → review-
Updated•9 years ago
|
Flags: needinfo?(sdat27)
Reporter | ||
Comment 2•9 years ago
|
||
Can you check if you are able to apply this patch? I added it as an attachment. Thanks, Sneha
Comment 3•9 years ago
|
||
(In reply to Sneha Datla from comment #2) > Can you check if you are able to apply this patch? I added it as an > attachment. It still didn't apply. Have you done 'hg pull -u' recently?
Flags: needinfo?(sdat27)
Reporter | ||
Comment 4•9 years ago
|
||
I followed the steps listed here https://wiki.mozilla.org/Partnering/Repacks/Submitting_Changes in 'Creating a Patch' section. I did 'hg pull && hg update -r default' before making my changes.
Comment 5•9 years ago
|
||
Comment on attachment 8582680 [details] [diff] [review] repack_config_changes_for_yahoo.diff https://hg.mozilla.org/build/partner-repacks/rev/1452264ae92e The problem was differing line endings in the files, I fixed that and pushed.
Attachment #8582680 -
Flags: review- → review+
Comment 6•9 years ago
|
||
actual yahoo patch https://hg.mozilla.org/build/partner-repacks/rev/df17e070d04e
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•2 years ago
|
Component: Custom Release Requests → Release Requests
You need to log in
before you can comment on or make changes to this bug.
Description
•