1147262 - Startup failure on simulator in Profile.swift

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Pulled latest code and built fine. Tried to launch in iPhone 5 simulator and I get a failure:

"fatal error: unexpectedly found nil while unwrapping an Optional value"

Line 13 of Profile.swift

 let url = NSFileManager.defaultManager().containerURLForSecurityApplicationGroupIdentifier(ExtensionUtils.sharedContainerIdentifier())!

Comment 1

[Richard Newman [:rnewman]]

Sounds like fallout from st3fan's fix for our extensions?

Comment 2

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I can't reproduce this issue. Tried with several simulator types and on two devices. Is anyone else seeing this?

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

I am pretty sure now that this is happening because Mark has not setup his Mac to do device builds. That means that the provisioning profiles for org.mozilla.ios.Fennec are not present. And those profiles contain the reference to the application group.

As a fallback we can use ~/Documents if containerURLForSecurityApplicationGroupIdentifier() fails, but that has the side effect that the share extension does not work. This may be ok because that is only a situation that can happen when the app is run in the simulator. On a device, containerURLForSecurityApplicationGroupIdentifier, cannot fail. (Famous last words, but it would only fail if the app were packaged incorrectly with wrong or missing entitlements)

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/288

Comment 5

[Nick Alexander :nalexander [he/him]]

stefan: I think we'll land a work-around to get the simulator back for contributors, but please follow-up with a longer term bug if there's more needed.

Comment 6

[Richard Newman [:rnewman]]

Comment on attachment 8585195 [details] [review]
Link to Github pull-request: https://github.com/mozilla/firefox-ios/pull/288

Works on device.

Comment 7

[Nick Alexander :nalexander [he/him]]

https://github.com/mozilla/firefox-ios/commit/e674e80b32c0817caded489213e5948a192f3c55