1147297 - Assertion failure Assertion failure: adjust > 0, at gfx/thebes/gfxWindowsPlatform.cpp:2104

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jean-Yves Avenard [:jya]]

Hitting this 100% of the time on my windows debug build.


Assertion failure: adjust > 0, at c:/Users/Developer/Work/Mozilla/mozilla-centra
l/gfx/thebes/gfxWindowsPlatform.cpp:2104
#01: DispatchToMethod<D3DVsyncSource::D3DVsyncDisplay,void (__thiscall D3DVsyncS
ource::D3DVsyncDisplay::*)(void)> (c:\users\developer\work\mozilla\mozilla-centr
al\ipc\chromium\src\base\tuple.h:384)
#02: RunnableMethod<D3DVsyncSource::D3DVsyncDisplay,void (__thiscall D3DVsyncSou
rce::D3DVsyncDisplay::*)(void),Tuple0>::Run (c:\users\developer\work\mozilla\moz
illa-central\ipc\chromium\src\base\task.h:310)
#03: MessageLoop::RunTask (c:\users\developer\work\mozilla\mozilla-central\ipc\c
hromium\src\base\message_loop.cc:362)
#04: MessageLoop::DeferOrRunPendingTask (c:\users\developer\work\mozilla\mozilla
-central\ipc\chromium\src\base\message_loop.cc:372)
#05: MessageLoop::DoWork (c:\users\developer\work\mozilla\mozilla-central\ipc\ch
romium\src\base\message_loop.cc:456)
#06: base::MessagePumpDefault::Run (c:\users\developer\work\mozilla\mozilla-cent
ral\ipc\chromium\src\base\message_pump_default.cc:34)
#07: MessageLoop::RunInternal (c:\users\developer\work\mozilla\mozilla-central\i
pc\chromium\src\base\message_loop.cc:234)
#08: MessageLoop::RunHandler (c:\users\developer\work\mozilla\mozilla-central\ip
c\chromium\src\base\message_loop.cc:227)
#09: MessageLoop::Run (c:\users\developer\work\mozilla\mozilla-central\ipc\chrom
ium\src\base\message_loop.cc:201)
#10: base::Thread::ThreadMain (c:\users\developer\work\mozilla\mozilla-central\i
pc\chromium\src\base\thread.cc:173)
#11: `anonymous namespace'::ThreadFunc (c:\users\developer\work\mozilla\mozilla-
central\ipc\chromium\src\base\platform_thread_win.cc:27)
#12: BaseThreadInitThunk[KERNEL32 +0x17c04-]
-DOCSHELL 0CD04C00 == 12 [pid = 2792] [id = 13]
#13: RtlInitializeExceptionChain[ntdll +0x5b54f]
#14: RtlInitializeExceptionChain[ntdll +0x5b51a]

>	xul.dll!D3DVsyncSource::D3DVsyncDisplay::VBlankLoop() Line 2104	C++
 	xul.dll!DispatchToMethod<D3DVsyncSource::D3DVsyncDisplay,void (__thiscall D3DVsyncSource::D3DVsyncDisplay::*)(void)>(D3DVsyncSource::D3DVsyncDisplay * obj, void (void) * method, const Tuple0 & arg) Line 384	C++
 	xul.dll!RunnableMethod<D3DVsyncSource::D3DVsyncDisplay,void (__thiscall D3DVsyncSource::D3DVsyncDisplay::*)(void),Tuple0>::Run() Line 310	C++
 	xul.dll!MessageLoop::RunTask(Task * task) Line 362	C++
 	xul.dll!MessageLoop::DeferOrRunPendingTask(const MessageLoop::PendingTask & pending_task) Line 372	C++
 	xul.dll!MessageLoop::DoWork() Line 456	C++
 	xul.dll!base::MessagePumpDefault::Run(base::MessagePump::Delegate * delegate) Line 34	C++
 	xul.dll!MessageLoop::RunInternal() Line 234	C++
 	xul.dll!MessageLoop::RunHandler() Line 227	C++
 	xul.dll!MessageLoop::Run() Line 201	C++
 	xul.dll!base::Thread::ThreadMain() Line 173	C++
 	xul.dll!`anonymous namespace'::ThreadFunc(void * closure) Line 27	C++
 	[External Code]	
 	[Frames below may be incorrect and/or missing, no symbols loaded for kernel32.dll]

Comment 1

[Jean-Yves Avenard [:jya]]

adjust here is 0.

Changing that assertion to be >= 0 and I don't see any ill-effect (except of course that it doesn't crash anymore)

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Fix assertion to be >=

Thanks for finding this. Yeah there are no negative consequences from having it be >=. It means that the thread wokeup right after vsync when usually there is some amount of delay.

Comment 3

[Mason Chang [Inactive] [:mchang]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/0ed97c76d58c

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0ed97c76d58c