1147446 - We should take Chromium fix in commit b533d6533585377edd63ec6500469f6c4fba602a to stop a memory leak.

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect)

Description

[Bob Owen (:bobowen)]

See https://codereview.chromium.org/831423002/ for details.

This may not have been biting us much, but could start to with EME coming along.

Comment 1

[Bob Owen (:bobowen)]

Attachment: Chromium patch to fix memory leak in Windows sandbox sharedmem_ipc_server.cc.

In my not very scientific test, if I run multiple GMP tests with [1] the baseline memory certainly seems to climb.
This doesn't happen with the fix.

I took the other change that had happened in the file as well, as it makes no functional difference.

[1] http://mozilla.github.io/webrtc-landing/pc_test.html

Comment 2

[Bob Owen (:bobowen)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/f3cc3b904308

Thanks for the quick review Aaron, particularly given how busy you are this week.

Comment 3

[Bob Owen (:bobowen)]

Comment on attachment 8583238 [details] [diff] [review]
Chromium patch to fix memory leak in Windows sandbox sharedmem_ipc_server.cc.

Approval Request Comment
[Feature/regressing bug #]:
This has been in the Chromium Windows sandbox code since we shipped it.
(In fact since Chromium shipped it as well.)

[User impact if declined]:
Going by the Chromium bug comments, each sandboxed process will continue to leak 64KB when it shuts down.
We are likely to be getting more GMP processes with EME shipping in Fx38.

[Describe test coverage new/current, TreeHerder]:
The only things that we ship that use the sandbox are GMPs (OpenH264 and soon to be EME) and these have mochitests.

[Risks and why]:
Low: It's a small obvious fix and is already shipping in the Chrome stable release (announced 3rd March).

[String/UUID change made/needed]:
None.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f3cc3b904308

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b3872e186f0