1147707 - DisplayItemClip::ApplyNonRoundedIntersection doesn't intersect correctly

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Seth Fowler [:seth] [:s2h]]

The patch in bug 1147706 made it apparent that we have a bug in DisplayItemClip::ApplyNonRoundedIntersection. See here:

https://dxr.mozilla.org/mozilla-central/source/layout/base/DisplayItemClip.cpp?from=ApplyNonRoundedIntersection&case=true#330

That line of code doesn't do anything, because Intersect() returns a new rect which we immediately destroy.

Comment 1

[Seth Fowler [:seth] [:s2h]]

Attachment: Intersect correctly in DisplayItemClip::ApplyNonRoundedIntersection

Here's the patch.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8583526 [details] [diff] [review]
Intersect correctly in DisplayItemClip::ApplyNonRoundedIntersection

Review of attachment 8583526 [details] [diff] [review]:
-----------------------------------------------------------------

OW!

Comment 3

[Seth Fowler [:seth] [:s2h]]

Thanks for the review! Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/950e7c72280a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/950e7c72280a