1148012 - Add a run ID to NPAPI plugins.

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Split out from bug 1110887.

In order to differentiate different "runs" of a plugin process, I propose adding a run ID that can be exposed via nsIObjectLoadingContent. This is necessary for the plugin crash UI work I'm doing in bug 1110887.

While the run ID seems to serve the same purpose as the process ID, I felt like the process ID is too much of a system-level bit of data to expose to chrome-level JS.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r 2c405f53cc691446b6dfbae1fb7ea194ba18e674

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Hey Josh - additional context for this is in bug 1110887 comment 10 and bug 1110887 comment 12.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

https://reviewboard.mozilla.org/r/6165/#review5163

::: dom/base/nsObjectLoadingContent.cpp
(Diff revision 1)
> +  if (NS_WARN_IF(!aRunID) {

Bah - goofed here in a refactor. Missing a closing parenthesis - I'll update the patch...

Comment 6

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=?
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r 05cffc803255f549feeee8aa96a6df6ade4247ff

Comment 7

[Josh Aas]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

https://reviewboard.mozilla.org/r/6161/#review5265

::: dom/plugins/base/nsNPAPIPluginInstance.cpp
(Diff revision 2)
> +    return NS_ERROR_FAILURE;

Always use {} for if blocks in this code.

::: dom/plugins/base/nsNPAPIPluginInstance.cpp
(Diff revision 2)
> +  PluginLibrary* library = mPlugin->GetLibrary();

Probably best to check that mPlugin is not null.

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748

Comment 9

[Josh Aas]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

https://reviewboard.mozilla.org/r/6161/#review5499

Comment 10

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748

Comment 11

[Mike Conley (:mconley) (:⚙️)]

I hit this when trying to push to inbound:

remote: ************************** ERROR ****************************
remote:
remote: WebIDL file dom/webidl/HTMLObjectElement.webidl altered in changeset 7ae748601cc4 without DOM peer review
remote:
remote:
remote: Changes to WebIDL files in this repo require review from a DOM peer in the form of r=...
remote: This is to ensure that we behave responsibly with exposing new Web APIs. We appreciate your understanding..
remote:
remote: *************************************************************

And I believe mrbkap is a DOM peer.

Comment 12

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

r+ for the .webidl change.

Comment 13

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8583955 [details]
MozReview Request: bz://1148012/mconley

/r/6163 - Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.
/r/6165 - Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?
/r/6167 - Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?

Pull down these commits:

hg pull review -r a19ce82f52e61cd4f9361ee7f9afea5ca1ed6748

Comment 14

[Mike Conley (:mconley) (:⚙️)]

Thanks for the reviews,

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/a423c6fdc3d4
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/fb8373ac7558
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/84d46805a079

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a423c6fdc3d4
https://hg.mozilla.org/mozilla-central/rev/fb8373ac7558
https://hg.mozilla.org/mozilla-central/rev/84d46805a079

Comment 17

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1148012 - Add a run ID for plugins to differentiate subsequent runs of the same plugins. r=jimm.

Comment 18

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1148012 - Expose run ID through nsIObjectLoadingContent.idl. r=?

Comment 19

[Mike Conley (:mconley) (:⚙️)]

Attachment: MozReview Request: Bug 1148012 - Send the run ID and plugin name along with the plugin-crashed observer notification. r=?