1148220 - Marionette's in_app restart has to send 'quit-application-requested' observer notification before an in_app restart

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Barbara Miller (:galgeek)]

Firefox UI Tests' restart() method currently fails to store open tabs properly unless preceded by additional code like this:

        self.marionette.execute_script("""
          Components.utils.import("resource://gre/modules/Services.jsm");
          let cancelQuit = Components.classes["@mozilla.org/supports-PRBool;1"]
                                     .createInstance(Components.interfaces.nsISupportsPRBool);
          Services.obs.notifyObservers(cancelQuit, "quit-application-requested", null);
        """)

It would be good to add this to the restart() method, perhaps via a parameter, since this won't matter to many tests.

Chris Manchester first reported this here: https://bugzilla.mozilla.org/show_bug.cgi?id=1132701#c4

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's what I told Chris when he was working on the in_app restart functionality of Marionette. See bug 1137388 comment 11. He told that this is not necessary. But it looks like it is. So this is a Marionette bug and nothing we have to do in our tests.

Comment 2

[Chris Manchester (limited bugmail, email directly)]

(In reply to Henrik Skupin (:whimboo) [away 03/25 - 03/31] from comment #1)
> That's what I told Chris when he was working on the in_app restart
> functionality of Marionette. See bug 1137388 comment 11. He told that this
> is not necessary. But it looks like it is. So this is a Marionette bug and
> nothing we have to do in our tests.

Clearly the significance of that comment was lost. Fortunately we figured out the issue as soon as it came up and this code can easily be added in marionette or anywhere it's needed.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1148220 - Marionette's in_app restart has to send 'quit-application-requested' observer notification.

Review commit: https://reviewboard.mozilla.org/r/81100/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81100/

Comment 4

[David Burns :automatedtester]

Comment on attachment 8794806 [details]
Bug 1148220 - Marionette's in_app restart has to send 'quit-application-requested' observer notification.

https://reviewboard.mozilla.org/r/81100/#review80254

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b99e97b8f228
Marionette's in_app restart has to send 'quit-application-requested' observer notification. r=automatedtester

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b99e97b8f228