Closed
Bug 1148268
Opened 9 years ago
Closed 9 years ago
[DeviceStorage] misspelling attribute "mActorDestoryed"
Categories
(Core :: DOM: Device Interfaces, defect)
Tracking
()
RESOLVED
FIXED
mozilla40
Tracking | Status | |
---|---|---|
firefox40 | --- | fixed |
People
(Reporter: schien, Assigned: ewu)
Details
(Whiteboard: [good first bug])
Attachments
(1 file, 4 obsolete files)
2.47 KB,
patch
|
ewu
:
review+
|
Details | Diff | Splinter Review |
trivial bug. simple replace it with "mActorDestroyed". https://dxr.mozilla.org/mozilla-central/source/dom/devicestorage/DeviceStorageRequestParent.h#310
Hi, Could you please help to review this patch? thanks.
Attachment #8584370 -
Flags: review?(sku)
Attachment #8584370 -
Flags: review?(schien)
Reporter | ||
Comment 2•9 years ago
|
||
Comment on attachment 8584370 [details] [diff] [review] bug_1148268.patch Review of attachment 8584370 [details] [diff] [review]: ----------------------------------------------------------------- You'll also need to update all the code that reference this attribute, otherwise it won't compile, right?
Attachment #8584370 -
Flags: review?(sku)
Attachment #8584370 -
Flags: review?(schien)
Hi Shih-Chiang, Thanks you for your reminder. this patch will update all the code that reference this attribute. thanks.
Attachment #8584414 -
Flags: review?(schien)
Reporter | ||
Comment 4•9 years ago
|
||
Comment on attachment 8584414 [details] [diff] [review] bug_1148268_part2.patch Review of attachment 8584414 [details] [diff] [review]: ----------------------------------------------------------------- lgtm! you need to merge these two patch files into one, and follow [1] to provide the checkin comment. Then, r? dhyland because he is the module owner. Since this is your first patch, please provide the try result as a practice even though it is a trivial patch. :) [1] https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Committing_Rules_and_Responsibilities
Attachment #8584414 -
Flags: review?(schien) → feedback+
Hi Shih-Chiang. Update correct patch and the try result as below [1] link. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=324a02b52a6e
Attachment #8585296 -
Flags: review?(schien)
Reporter | ||
Comment 6•9 years ago
|
||
Comment on attachment 8585296 [details] [diff] [review] bug-1148268-fix_20150330.patch Review of attachment 8585296 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, as I mentioned in comment #4 you should change the reviewer to dhyland. Be sure to modify "r=schien" to "r=dhyland" in your checkin comment. BTW, you can mark those out-dated patches as "obsolete" (follow the "Details" link in attachments section, then click "edit details").
Attachment #8585296 -
Flags: review?(schien) → review?(dhylands)
Attachment #8584370 -
Attachment is obsolete: true
Attachment #8584414 -
Attachment is obsolete: true
Attachment #8585296 -
Flags: review?(dhylands)
Attachment #8585296 -
Attachment is obsolete: true
Attachment #8585334 -
Flags: review?(dhylands)
Comment 8•9 years ago
|
||
Comment on attachment 8585334 [details] [diff] [review] Bug 1148268 - [DeviceStorage] misspelling attribute "mActorDestoryed" Review of attachment 8585334 [details] [diff] [review]: ----------------------------------------------------------------- Looks good - thanks for taking the time to fix this.
Attachment #8585334 -
Flags: review?(dhylands) → review+
Hi, The result of try is as below [1] link. [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=2eb6b669abd0
Attachment #8585334 -
Attachment is obsolete: true
Attachment #8585834 -
Flags: review+
Keywords: checkin-needed
Comment 10•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/86578daf0154
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/86578daf0154
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
You need to log in
before you can comment on or make changes to this bug.
Description
•