1148369 - "invalid 'in' operand colState" when switching folders

Reporter

Description

•

9 years ago

I get this exception when swithing into SOME of my columns on TB trunk.

Error: invalid 'in' operand colState
Source File: chrome://messenger/content/folderDisplay.js
Line: 598

The code is like this:
if (colChild.id in aColumnStates) {
   let colState = aColumnStates[colChild.id];
   if ("visible" in colState)               <--- error
      shouldBeHidden = !colState.visible;

May 'colState' be null or something that can't be queried with "in" operand?
May this be something caused by bug 36489 where a new column ID was added?

neil@parkwaycc.co.uk

Assignee

Comment 1

•

9 years ago

I think the problem might be to do with the default column states for a folder.

When you visit a folder for the first time, it inherits its settings from the Inbox. When you visit the folder again with a correspondent column build, the code tries to upgrade the settings. To do this, it checks whether the correspondent column would be shown by default in this folder. However, the default for a folder is to inherit the settings from the Inbox, which fools the upgrade code.

I assume that you don't see this message for:
* The Inbox itself
* The Drafts, Outbox, Sent, or Tamplates folder
* A saved search folder
* A news folder

If you open a folder in which the error occurs, what is the result of this code:
JSON.stringify(top.opener.gFolderDisplay._getDefaultColumnsForCurrentFolder())

neil@parkwaycc.co.uk

Assignee

Comment 2

•

9 years ago

Attached patch Proposed patch — Details — Splinter Review

Attachment #8584882 - Flags: feedback?(acelists)

:aceman

Reporter

Comment 3

•

9 years ago

Comment on attachment 8584882 [details] [diff] [review]
Proposed patch

Review of attachment 8584882 [details] [diff] [review]:
-----------------------------------------------------------------

When I added the bracket as described below I got no longer the original error into console.

::: mail/base/content/folderDisplay.js
@@ +690,5 @@
>     */
>    _restoreColumnStates: function FolderDisplayWidget__restoreColumnStates() {
>      if (this._savedColumnStates) {
>        // upgrade column states that don't have a correspondent column
> +      if (!("correspondentCol" in this._savedColumnStates))

There probably needs to be a { at the end as otherwise the whole file is hosed syntactically.

Attachment #8584882 - Flags: feedback?(acelists) → feedback+

neil@parkwaycc.co.uk

Assignee

Comment 4

•

9 years ago

(In reply to aceman from comment #3)
> There probably needs to be a {

Sorry about that. I forgot to actually try the fix out after updating and fixing the merge conflict.

ISHIKAWA, Chiaki

Comment 5

•

9 years ago

I was about to post a bug regarding this 
TypeError "invalid 'in' operand colState".

Actually, this bug seems to cause test failures in |make mozmill| test suite run.
I am quoting the memo which I was about to file
in the following so that if Neil can confirm if the proposed patch is likely to solve the issues in |make mozmill| run.

Or should I file a separate bug?

TIA

---

C-C TB: TypeError: invalid 'in' operand colState"

Staring on March 29th (after source refresh), I noticed the following
EXCEPTIONs and new TypeError
during local runs of |make mozmill| test suite.

I excerpt the 6 EXCEPTION lines.

(1)
SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_multiple_messages_without_backing_views_in_tabs
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA

(2)
SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_new_window
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA

(3)
SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_existing_window
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA

(4)
SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_multiple_messages_without_backing_views_in_tabs_filtered
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA

(5)

SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_new_window_filtered
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA


(6)
SUMMARY-UNEXPECTED-FAIL | test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_existing_window_filtered
  EXCEPTION: Timeout trying to enter folder mailbox://nobody@Local%20Folders/OpeningMessagesNoBackingViewA


I think at least some of the failures are related to
sytnax/runtime errors reported about "TypeError: invalid 'in' operand
colState" which precedes the tests that caused EXCEPTION.

e.g.: TypeError: This is the first occurence in the log.

--- begin quote ---

TypeError: invalid 'in' operand colState
-- Exception object --
*
-- Stack Trace --
FolderDisplayWidget.prototype.setColumnStates@chrome://messenger/content/folderDisplay.js:598:1
FolderDisplayWidget__restoreColumnStates@chrome://messenger/content/folderDisplay.js:717:7
FolderDisplayWidget_makeActive@chrome://messenger/content/folderDisplay.js:1666:7
mailTabType.modes.message.openTab@chrome://messenger/content/mailTabs.js:380:11
openTab@chrome://messenger/content/tabmail.xml:559:1
MailUtils_displayMessages@resource:///modules/MailUtils.js:194:11
MailUtils_displayMessage@resource:///modules/MailUtils.js:119:5
test_open_single_message_without_backing_view_in_tab@resource://mozmill/modules/frame.js -> file:///REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js:56:3
Runner.prototype.wrapper@resource://mozmill/modules/frame.js:585:9
Runner.prototype._runTestModule@resource://mozmill/modules/frame.js:655:9
Runner.prototype.runTestModule@resource://mozmill/modules/frame.js:701:3
Runner.prototype.runTestDirectory@resource://mozmill/modules/frame.js:525:7
runTestDirectory@resource://mozmill/modules/frame.js:707:3
Bridge.prototype._execFunction@resource://jsbridge/modules/server.js:179:10
Bridge.prototype.execFunction@resource://jsbridge/modules/server.js:183:16
@resource://jsbridge/modules/server.js:283:1
Session.prototype.receive@resource://jsbridge/modules/server.js:283:3
AsyncRead.prototype.onDataAvailable@resource://jsbridge/modules/server.js:88:3
--- end quote ---

I notice that this TypeError occurs twice in a series of tests that are
executed back to back, and after the error occurs, we see the tests that caused
exception above. I put the number (1)-(6) at the beginning of line of
the start of tests that caused the exception as noted above.

The following output is created by
egrep "(TEST-START|TEST-PASS|TEST-UN|TypeError: invalid 'in' operand colState)" log615-mozmill-original-ASAN.txt

--- begin quote ---
    ...

    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_single_message_without_backing_view_in_tab
(*) TypeError: invalid 'in' operand colState
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_single_message_without_backing_view_in_tab
(1) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_multiple_messages_without_backing_views_in_tabs
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_multiple_messages_without_backing_views_in_tabs
(2) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_message_without_backing_view_in_new_window
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_new_window
(3) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_message_without_backing_view_in_existing_window
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_existing_window
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_filter_out_all_messages
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_filter_out_all_messages
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_single_message_without_backing_view_in_tab_filtered
(*) TypeError: invalid 'in' operand colState
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_single_message_without_backing_view_in_tab_filtered
(4) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_multiple_messages_without_backing_views_in_tabs_filtered
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_multiple_messages_without_backing_views_in_tabs_filtered
(5) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_message_without_backing_view_in_new_window_filtered
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_new_window_filtered
(6) TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test_open_message_without_backing_view_in_existing_window_filtered
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/folder-display/test-opening-messages-without-a-backing-view.js | test-opening-messages-without-a-backing-view.js::test_open_message_without_backing_view_in_existing_window_filtered
    ...
--- end quote

As for
the TypeError:, I see a few more appearances and they seem to cause
failure of tests as in the following.
I wonder if I should file another bug for them.

    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test_tab_reorder_window
(*) JavaScript error: chrome://messenger/content/folderDisplay.js, line 598: TypeError: invalid 'in' operand colState
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | teardownTest
    TEST-PASS | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::teardownTest
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_reorder_window
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test_tab_reorder_detach
(*) JavaScript error: chrome://messenger/content/folderDisplay.js, line 598: TypeError: invalid 'in' operand colState
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | teardownTest
    TEST-PASS | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::teardownTest
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_reorder_detach
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test_tab_undo
(*) JavaScript error: chrome://messenger/content/folderDisplay.js, line 598: TypeError: invalid 'in' operand colState
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | teardownTest
    TEST-PASS | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::teardownTest
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_undo
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test_tab_recentlyClosed
(*) JavaScript error: chrome://messenger/content/folderDisplay.js, line 598: TypeError: invalid 'in' operand colState
    TEST-START | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | teardownTest
    TEST-PASS | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::teardownTest
    TEST-UNEXPECTED-FAIL | /REF-COMM-CENTRAL/comm-central/mail/test/mozmill/tabmail/test-tabmail-dragndrop.js | test-tabmail-dragndrop.js::test_tab_recentlyClosed

I have not seen these errors before.
So this is fairly new.

TIA

ISHIKAWA, Chiaki