1148479 - Unify string conversions in mozAccessible.mm

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

Attachment: Clean up string conversion calls

There are two instances in MozAccessible.mm where we don't use the CocoaUtils::ToNSString method for conversion. This patch simply cleans that up.

Comment 1

[alexander :surkov (:asurkov)]

Comment on attachment 8584652 [details] [diff] [review]
Clean up string conversion calls

Review of attachment 8584652 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/mac/mozAccessible.mm
@@ +539,5 @@
>    NS_OBJC_BEGIN_TRY_ABORT_BLOCK_NIL;
>  
>    nsAutoString value;
>    mGeckoAccessible->Value(value);
> +  return nsCocoaUtils::ToNSString(value);

the only difference is we used to return nil, but ToNSString returns empty string, but since we use ToNSString for title and description then we should be good to do so for value and help so r=me

Comment 2

[Marco Zehe (:MarcoZ)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/76f46106d07e

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/76f46106d07e