1148835 - Combine urlbar and bottom toolbar in landscape and on tablets

Status: RESOLVED FIXED

(Firefox for iOS :: General, defect)

Comment 1

[Wesley Johnston (:wesj)]

I have a WIP for this here: https://github.com/wesj/firefox-ios-1/tree/landscapeToolbar

Comment 2

[Wesley Johnston (:wesj)]

Attachment: PR: https://github.com/mozilla/firefox-ios/pull/295

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8587069 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/295

Approach is OK, but I think this could use a fair amount of cleanup first. Also, let's be careful to avoid regressing the toolbar behavior on about:home.

Comment 4

[Wesley Johnston (:wesj)]

I've been playing lately and noticed that snackbar's don't show on about:home. We need to redo that approach. Its too fragile. I'll file a bug for it.

Comment 5

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Comment on attachment 8587069 [details] [review]
PR: https://github.com/mozilla/firefox-ios/pull/295

I don't have much to add on top of brian's review. Just one thing:

This introduced a regression with the share popover: on iPad, tapping the share button greys out the screen but does not actually show the popover.

Can that be fixed as part of this PR? It is probably just a matter of specifying the correct source view/rect.

Comment 6

[Wesley Johnston (:wesj)]

I'm taking my r+ and running!

Comment 7

[Wesley Johnston (:wesj)]

Had to land a follow up: https://github.com/mozilla/firefox-ios/pull/314