Closed
Bug 1148887
Opened 9 years ago
Closed 9 years ago
Message string for SMTP server connection error is incorrect. File: composeMsgs.properties, key: smtpSendRefused
Categories
(MailNews Core :: Composition, defect)
MailNews Core
Composition
Tracking
(thunderbird40 fixed)
RESOLVED
FIXED
Thunderbird 40.0
| Tracking | Status | |
|---|---|---|
| thunderbird40 | --- | fixed |
People
(Reporter: iacchi, Assigned: sshagarwal)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
7.05 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
In composeMsgs.properties, the key smtpSendRefused shows the text "The message could not be sent because connecting to Outgoing server (SMTP) %S failed. The server may be unavailable or is refusing Outgoing server (SMTP) connections. Please verify that your Outgoing server (SMTP) settings are correct and try again." The previous instance of the string only reported "SMTP server" instead of "Outgoing server (SMTP)". This change is ok for the first and the last part of the sentence, but "is refusing Outgoing server (SMTP) connections" makes no sense, it should be "is refusing SMTP connections".
|
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8590430 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 2•9 years ago
|
||
Comment on attachment 8590430 [details] [diff] [review] Patch v1 Sorry it has issues.
Attachment #8590430 -
Attachment is obsolete: true
Attachment #8590430 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Comment 3•9 years ago
|
||
I forgot to change the string key. This patch fixes the issue. Thanks.
Attachment #8590441 -
Flags: review?(iann_bugzilla)
|
|
Assignee | |
Updated•9 years ago
|
Component: MailNews: Composition → Composition
Product: SeaMonkey → MailNews Core
|
||
Updated•9 years ago
|
Assignee: nobody → syshagarwal
Keywords: regression
Attachment #8590441 -
Flags: review?(iann_bugzilla) → review+
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8590441 [details] [diff] [review] Patch v1.1 a=me for SeaMonkey CLOSED TREE
|
|
||
Comment 6•9 years ago
|
||
https://hg.mozilla.org/comm-central/rev/a195e2c4d205
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-thunderbird40:
--- → fixed
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
You need to log in
before you can comment on or make changes to this bug.
Description
•