1149162 - [e10s] test-tab.js causes unsafe CPOW usage warnings

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Mike Conley (:mconley) (:⚙️)]

Mined from test logs

In addon-sdk/source/test/tabs/test-tab.js:

https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l66
https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l71
https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l72
https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l77
https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l78
https://hg.mozilla.org/projects/holly/file/50e197279ad5/addon-sdk/source/test/test-tab.js#l83

function step2(url, assert) {

  tabs.open({
    url: url,
    onReady: function(tab) {
      primaryTab = tab;
      let window = windowUtils.activeBrowserWindow.content;

      let matchedTab = getTabForWindow(window);
      assert.equal(matchedTab, tab,
        "We are able to find the tab with his content window object");

      let timer = require("sdk/timers");
      function waitForFrames() {
        let iframe = window.document.getElementById("iframe"); <-- causes unsafe CPOW usage warning
        if (!iframe) {
          timer.setTimeout(waitForFrames, 100);
          return;
        }
        iframeWin = iframe.contentWindow; <-- causes unsafe CPOW usage warning
        let subIframe = iframeWin.document.getElementById("sub-iframe"); <-- causes unsafe CPOW usage warning
        if (!subIframe) {
          timer.setTimeout(waitForFrames, 100);
          return;
        }
        let subIframeWin = subIframe.contentWindow; <-- causes unsafe CPOW usage warning
        let subSubIframe = subIframeWin.document.getElementById("sub-sub-iframe"); <-- causes unsafe CPOW usage warning
        if (!subSubIframe) {
          timer.setTimeout(waitForFrames, 100);
          return;
        }
        let subSubIframeWin = subSubIframe.contentWindow; <-- causes unsafe CPOW usage warning

        matchedTab = getTabForWindow(iframeWin);
        assert.equal(matchedTab, tab,
          "We are able to find the tab with an iframe window object");

        matchedTab = getTabForWindow(subIframeWin);
        assert.equal(matchedTab, tab,
          "We are able to find the tab with a sub-iframe window object");

        matchedTab = getTabForWindow(subSubIframeWin);
        assert.equal(matchedTab, tab,
          "We are able to find the tab with a sub-sub-iframe window object");

        // Put our primary tab in the background and test again.
        // The onActivate listener will take us to step3.
        auxTab.activate();
      }
      waitForFrames();
    }
  });
}

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This is test only.

Comment 2

[:shell escalante]

Luca has fix believes

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: bug1149162-test-tab-cpow.patch

The cpows usage described in Comment 0 has been fixed by Bug 1171515 (which has been merge into mozilla-central as part of Bug 1179013).

Nevertheless, in the meantime this test file has got a new single cpow usage which has been added by Bug 1179013, which means that I added the only cpow currently used in this test file :-(

This cpow usage can be removed by the tests by using the message manager to retrieve the current value of the document.readyState, without using the CPOW.

I'm attaching the patch that remove the cpow usage from this test, using the strategy described above.

Comment 4

[Luca Greco [:rpl] [:luca] [:lgreco]]

Pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c058a8366249c3620e848bc265fde74671fef011

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3b4965bb11c0
Remove CPOW shim usage in SDK test-tab test related to tab.readyState. r=Mossop

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b4965bb11c0

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/188c28fdb1aa

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/79247eb8ce1f