1149696 - Display a message when add-on installation fails because it isn't signed

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Dave Townsend [:mossop]]

Attachment: mockup

UX taken from bug 1120996.

Comment 1

[Dave Townsend [:mossop]]

Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox has prevented this site from installing an uncertified add-on".

Probably as addonError-5 and addonLocalError-5: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#72

Comment 2

[Dave Townsend [:mossop]]

Also a "Learn more..." string.

Comment 3

[Dave Townsend [:mossop]]

[Tracking Requested - why for this release]:

First two stages of add-ons signing work are targeted at Firefox 39.

Comment 4

[Dão Gottwald [:dao]]

(In reply to Dave Townsend [:mossop] from comment #1)
> Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox
> has prevented this site from installing an uncertified add-on".
> 
> Probably as addonError-5 and addonLocalError-5:
> http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/
> browser/browser.properties#72

Can this message cover multiple add-ons? I.e. do we need to use the plural form?

(In reply to Dave Townsend [:mossop] from comment #2)
> Also a "Learn more..." string.

Popup notifications have built-in support for such a link, no separate string is needed.

Comment 5

[Dave Townsend [:mossop]]

(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Dave Townsend [:mossop] from comment #1)
> > Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox
> > has prevented this site from installing an uncertified add-on".
> > 
> > Probably as addonError-5 and addonLocalError-5:
> > http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/
> > browser/browser.properties#72
> 
> Can this message cover multiple add-ons? I.e. do we need to use the plural
> form?

The failure cases are displayed with a different panel for each add-on (http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser-addons.js#138). Not great but fine for now so no we don't need the plural form.

> (In reply to Dave Townsend [:mossop] from comment #2)
> > Also a "Learn more..." string.
> 
> Popup notifications have built-in support for such a link, no separate
> string is needed.

Awesome!

Comment 6

[Dave Townsend [:mossop]]

(In reply to Dave Townsend [:mossop] from comment #1)
> Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox
> has prevented this site from installing an uncertified add-on".

This text doesn't really work for the case where we're installing from the local filesystem. Markus, what do you think to "This add-on could not be installed because it is uncertified." for that case?

Comment 7

[Markus Jaritz [:designakt] (UX)]

Attachment: 150402_AIP_local_file.jpg

What if we instead, opened a page behind the add-on install. We need this page for sideloaded and drag and drop anyway, if we do not want that an add-on doorhanger can appear over some random page. And for install via add-on manger the therm " this site" might even be correct.

Comment 8

[Markus Jaritz [:designakt] (UX)]

How can I test the sideload case. Dropping an xpi in the extension folder seams not to work.

Comment 9

[Dave Townsend [:mossop]]

(In reply to Markus Jaritz [:maritz] from comment #7)
> Created attachment 8587302 [details]
> 150402_AIP_local_file.jpg
> 
> What if we instead, opened a page behind the add-on install. We need this
> page for sideloaded and drag and drop anyway, if we do not want that an
> add-on doorhanger can appear over some random page. And for install via
> add-on manger the therm " this site" might even be correct.

We can talk about that after the bulk of the work for signed add-on support is complete, I don't want to scope creep 39 any further. Even without that we still need a string for the doorhanger if the user installs from the filesystem, e.g. a html page loaded from a network drive could trigger an install.

(In reply to Markus Jaritz [:maritz] from comment #8)
> How can I test the sideload case. Dropping an xpi in the extension folder
> seams not to work.

It should work as long as the add-on is named as <addon-ID>.xpi.

Comment 10

[Dave Townsend [:mossop]]

Bug 1038068 is now ready to land except for the string needed from comment 6.

Comment 11

[Markus Jaritz [:designakt] (UX)]

(In reply to Dave Townsend [:mossop] from comment #6)
> (In reply to Dave Townsend [:mossop] from comment #1)
> > Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox
> > has prevented this site from installing an uncertified add-on".
> 
> This text doesn't really work for the case where we're installing from the
> local filesystem. Markus, what do you think to "This add-on could not be
> installed because it is uncertified." for that case?

For local files, what would appear in the line above instead of the domain? "Local File" ? If so, the current text might still work. I would like to keep "this site" in our texts as the user should always know where the file is coming from. If local install is so important that we need to change the text, we might consider having an alternative string for that case… I don't think so and would rather have a string that perfectly fits the web install case.

Comment 12

[Dave Townsend [:mossop]]

(In reply to Markus Jaritz [:maritz] from comment #11)
> (In reply to Dave Townsend [:mossop] from comment #6)
> > (In reply to Dave Townsend [:mossop] from comment #1)
> > > Based on the mockup we need to get this string in tree a.s.a.p.: "Firefox
> > > has prevented this site from installing an uncertified add-on".
> > 
> > This text doesn't really work for the case where we're installing from the
> > local filesystem. Markus, what do you think to "This add-on could not be
> > installed because it is uncertified." for that case?
> 
> For local files, what would appear in the line above instead of the domain?
> "Local File" ? If so, the current text might still work. I would like to
> keep "this site" in our texts as the user should always know where the file
> is coming from. If local install is so important that we need to change the
> text, we might consider having an alternative string for that case… I don't
> think so and would rather have a string that perfectly fits the web install
> case.

We currently don't display anything in the line above as technically these cases cover anything where we don't know the location of the install (might be a network drive for instance). We already have separate strings for all the other failure cases: http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.properties#80

Comment 13

[Dave Townsend [:mossop]]

Fixed by bug 1038068

Comment 14

[Vasilica Tamas, QA [:vtamas]]

(In reply to Dão Gottwald [:dao] from comment #4)
> (In reply to Dave Townsend [:mossop] from comment #1)
> > Also a "Learn more..." string.
> 
> Popup notifications have built-in support for such a link, no separate
> string is needed.

"Learn more..." string is not displayed for unsigned/corrupted warning messages:
- http://i.imgur.com/A7kYXH2.jpg
- http://i.imgur.com/3Gi1cpS.jpg
- http://i.imgur.com/0fmekeN.jpg
Tested on latest Firefox 40.0a2(2015-06-02) and Firefox 41.0a1(2015-06-02).

Is this mockup still valid https://bug1149696.bugzilla.mozilla.org/attachment.cgi?id=8586267 ?
Should "Learn more..." string be displayed in unsigned/corrupted warning messages?

Comment 15

[Dave Townsend [:mossop]]

(In reply to Vasilica Mihasca, QA [:vasilica_mihasca] from comment #14)
> (In reply to Dão Gottwald [:dao] from comment #4)
> > (In reply to Dave Townsend [:mossop] from comment #1)
> > > Also a "Learn more..." string.
> > 
> > Popup notifications have built-in support for such a link, no separate
> > string is needed.
> 
> "Learn more..." string is not displayed for unsigned/corrupted warning
> messages:
> - http://i.imgur.com/A7kYXH2.jpg
> - http://i.imgur.com/3Gi1cpS.jpg
> - http://i.imgur.com/0fmekeN.jpg
> Tested on latest Firefox 40.0a2(2015-06-02) and Firefox 41.0a1(2015-06-02).
> 
> Is this mockup still valid
> https://bug1149696.bugzilla.mozilla.org/attachment.cgi?id=8586267 ?
> Should "Learn more..." string be displayed in unsigned/corrupted warning
> messages?

I filed bug 1171146 for this.