1149729 - I was notified that my internet connection was down by Sync

Status: RESOLVED FIXED

(Firefox :: Sync, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

My wifi was acting up earlier and I saw this notification bar:

https://cloudup.com/inuC82EdsNz

I don't think these should ever appear.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: screenshot

Comment 2

[:Gavin Sharp [email: [e-mail]]]

I noticed this on mconley's livecoding stream too. Maybe something about the particular problem with Toronto wifi that causes this?

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Hopefully we'd always see an error log in about:sync-log in this case - seeing such a log would probably help.

Comment 4

[Mark Hammond [:markh] [:mhammond]]

Attachment: Error logs

Some trimmed error logs - I think the notification bar came up in the first log.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Attachment: 0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

I could reproduce the problem during the login phase, trying to fetch a token. While we ignored errors during the actual sync, we failed to ignore them during login.

There's a logging change that isn't strictly related to this, but should help if we see this again in different circumstances.

This patch fixes that and includes tests.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/105eaef4e0f1

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/105eaef4e0f1

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8596392 [details] [diff] [review]
0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

It's not a critical problem, but we might as well try and get this into beta IMO.

Approval Request Comment
[Feature/regressing bug #]: N/A
[User impact if declined]: Sync may repeated nag that it isn't working when there's a network issue.
[Describe test coverage new/current, TreeHerder]: New tests.
[Risks and why]: Log risk limited to Sync error UI
[String/UUID change made/needed]: None

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8596392 [details] [diff] [review]
0006-Bug-1149729-ignore-more-Sync-login-error-states.-r-a.patch

We are late in the beta cycle. I don't think it is critical for the release. Not taking it.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fd5e167468d2