Closed Bug 1150014 Opened 9 years ago Closed 9 years ago

Review Revision page should contain all unapproved revisions comment

Categories

(support.mozilla.org :: Knowledge Base Software, task)

Product:
support.mozilla.org
Component:
Knowledge Base Software
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: safwan, Assigned: safwan)

References

Details

Attachments

(1 file)

Proposed Patch
44 bytes, text/x-github-pull-request
Details | Review 
Referenced Bug 1112507:
Fixing Bug 699658 and Bug 1112507 started showing Revision comments in the Review page for All locals. But it only shows the comment of the revision being reviewed, we need previous comments as well until the revision marked "current".

Here is how it should look like: http://note.io/1qkVZ9b
See Also: → 1112507
Safwan and I chatted about this on irc. Let's display up to 5 most recent unreviewed revision comments.
Attached file Proposed Patch — 

    
  
Assignee: nobody → safwan.rahman15
Status: NEW → ASSIGNED

    
    

    
  
Landed:
https://github.com/mozilla/kitsune/commit/368cd46d9a64d909fdc4f15bcda9787496ac51b8

Pushed to prod by me, right now.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED

    
    

    
  
Topal, Can you please check if its working as you expected in Bug 696658?
Flags: needinfo?(a.topal)

    
    

    
  
Yes, thanks, Safwan!
Flags: needinfo?(a.topal)

    
  
See Also:  → 1235806

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: